From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Dan Williams <dan.j.williams@intel.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 9/9] isci: add version number
Date: Mon, 01 Aug 2011 12:54:46 -0500 [thread overview]
Message-ID: <1312221286.8212.29.camel@mulgrave> (raw)
In-Reply-To: <20110801193806.57dc9b58@stein>
On Mon, 2011-08-01 at 19:38 +0200, Stefan Richter wrote:
> On Aug 01 Dan Williams wrote:
> > On Sat, Jul 30, 2011 at 9:55 AM, Stefan Richter
> > <stefanr@s5r6.in-berlin.de> wrote:
> > > On Jul 29 Dan Williams wrote:
> > >> @@ -540,7 +548,8 @@ static __init int isci_init(void)
> > >> {
> > >> int err;
> > >>
> > >> - pr_info("%s: Intel(R) C600 SAS Controller Driver\n", DRV_NAME);
> > >> + pr_info("%s: Intel(R) C600 SAS Controller Driver - version %s\n",
> > >> + DRV_NAME, DRV_VERSION);
> > >
> > > Why? There is already a version number. Like 2.6.39, 3.0, 3.1.
> >
> > This is for tracking driver versions across distributions and driver
> > update packages as they sync with upstream on different cadences.
>
> If they "synced with upstream", they had just the kernel version number.
> You mean they "backport new drivers from current upstream into their branch
> with an old core".
This isn't good enough for distros, who often pretend to be on one
kernel version yet have the driver backported from another.
> The mainline doesn't generally carry stubs and macros that are only there
> for backporting. Well, I guess SCSI drivers are different in that regard.
This is hardly a stub for a backport. It's a printk printing the
version. At least 25% of drivers seem to do this (not that I entirely
approve ... it does tend to clutter the boot sequence a bit)
The whole reason for MODULE_VERSION() is to mark this correctly.
James
next prev parent reply other threads:[~2011-08-01 17:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-30 0:16 [GIT PATCH 0/9] isci updates for 3.1 Dan Williams
2011-07-30 0:16 ` [PATCH 1/9] isci: fix sata response handling Dan Williams
2011-07-30 0:16 ` [PATCH 2/9] isci: fix 32-bit operation when CONFIG_HIGHMEM64G=n Dan Williams
2011-07-30 0:16 ` [PATCH 3/9] isci: change sas phy timeouts from 54us to 59us Dan Williams
2011-07-30 0:16 ` [PATCH 4/9] isci: Update MAINTAINERS entry for the isci driver Dan Williams
2011-07-30 0:17 ` [PATCH 5/9] isci: Adding documentation to API change and fixup sysfs registration Dan Williams
2011-07-30 0:17 ` [PATCH 6/9] isci: Leave requests alone if already terminating Dan Williams
2011-07-30 0:17 ` [PATCH 7/9] isci: dynamic interrupt coalescing Dan Williams
2011-07-30 0:17 ` [PATCH 8/9] isci: fix event-get pointer increment Dan Williams
2011-07-30 0:17 ` [PATCH 9/9] isci: add version number Dan Williams
2011-07-30 16:55 ` Stefan Richter
2011-08-01 16:24 ` Dan Williams
2011-08-01 17:38 ` Stefan Richter
2011-08-01 17:54 ` James Bottomley [this message]
2011-08-01 18:29 ` Stefan Richter
2011-08-01 18:40 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312221286.8212.29.camel@mulgrave \
--to=james.bottomley@hansenpartnership.com \
--cc=dan.j.williams@intel.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox