From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH] [SCSI] aic7xxx: use kstrdup() Date: Sat, 06 Aug 2011 12:23:42 -0500 Message-ID: <1312651422.11515.37.camel@mulgrave> References: <1312622577.5589.63.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1312622577.5589.63.camel@localhost.localdomain> Sender: linux-kernel-owner@vger.kernel.org To: Thomas Meyer Cc: hare@suse.de, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On Sat, 2011-08-06 at 11:22 +0200, Thomas Meyer wrote: > From: Thomas Meyer > > Use kstrdup rather than duplicating its implementation > > The semantic patch that makes this output is available > in scripts/coccinelle/api/kstrdup.cocci. > > More information about semantic patching is available at > http://coccinelle.lip6.fr/ > > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/drivers/scsi/aic7xxx/aic79xx_osm_pci.c b/drivers/scsi/aic7xxx/aic79xx_osm_pci.c > --- a/drivers/scsi/aic7xxx/aic79xx_osm_pci.c 2010-09-13 07:01:17.520528007 +0200 > +++ b/drivers/scsi/aic7xxx/aic79xx_osm_pci.c 2011-08-01 21:15:58.925094946 +0200 > @@ -178,10 +178,9 @@ ahd_linux_pci_dev_probe(struct pci_dev * > ahd_get_pci_bus(pci), > ahd_get_pci_slot(pci), > ahd_get_pci_function(pci)); > - name = kmalloc(strlen(buf) + 1, GFP_ATOMIC); > + name = kstrdup(buf, GFP_ATOMIC); > if (name == NULL) > return (-ENOMEM); > - strcpy(name, buf); All adaptec drivers are in deep maintenance mode because the hardware isn't being produced any longer. The only things we really apply to them now is essential bug fixes, which this isn't. James