[PATCH] scsi: fix sparse warnings in FlashPoint.c

[PATCH] scsi: fix sparse warnings in FlashPoint.c

[Randy Dunlap]

From: Randy Dunlap <rdunlap@xenotime.net>

Fix sparse warnings in FlashPoint.c:

drivers/scsi/FlashPoint.c:2160:37: warning: non-ANSI function declaration of function 'FPT_SccbMgrTableInitAll'
drivers/scsi/FlashPoint.c:906:9: warning: Using plain integer as NULL pointer
drivers/scsi/FlashPoint.c:907:53: warning: Using plain integer as NULL pointer
drivers/scsi/FlashPoint.c:922:1: warning: Using plain integer as NULL pointer

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
 drivers/scsi/FlashPoint.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--- lnx-31-rc1.orig/drivers/scsi/FlashPoint.c
+++ lnx-31-rc1/drivers/scsi/FlashPoint.c
@@ -903,8 +903,8 @@ static void FPT_autoCmdCmplt(unsigned lo
 static void FPT_autoLoadDefaultMap(unsigned long p_port);
 
 static struct sccb_mgr_tar_info FPT_sccbMgrTbl[MAX_CARDS][MAX_SCSI_TAR] =
-    { {{0}} };
-static struct sccb_card FPT_BL_Card[MAX_CARDS] = { {0} };
+    { {{NULL}} };
+static struct sccb_card FPT_BL_Card[MAX_CARDS] = { {NULL} };
 static SCCBSCAM_INFO FPT_scamInfo[MAX_SCSI_TAR] = { {{0}} };
 static struct nvram_info FPT_nvRamInfo[MAX_MB_CARDS] = { {0} };
 
@@ -919,7 +919,7 @@ static unsigned char FPT_scamHAString[] 
 static unsigned short FPT_default_intena = 0;
 
 static void (*FPT_s_PhaseTbl[8]) (unsigned long, unsigned char) = {
-0};
+NULL};
 
 /*---------------------------------------------------------------------
  *
@@ -2157,7 +2157,7 @@ static unsigned char FPT_SccbMgr_bad_isr
  *
  *---------------------------------------------------------------------*/
 
-static void FPT_SccbMgrTableInitAll()
+static void FPT_SccbMgrTableInitAll(void)
 {
 	unsigned char thisCard;
 

Re: [PATCH] scsi: fix sparse warnings in FlashPoint.c

[James Bottomley]

On Mon, 2011-08-08 at 13:43 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> Fix sparse warnings in FlashPoint.c:
> 
> drivers/scsi/FlashPoint.c:2160:37: warning: non-ANSI function declaration of function 'FPT_SccbMgrTableInitAll'
> drivers/scsi/FlashPoint.c:906:9: warning: Using plain integer as NULL pointer
> drivers/scsi/FlashPoint.c:907:53: warning: Using plain integer as NULL pointer
> drivers/scsi/FlashPoint.c:922:1: warning: Using plain integer as NULL pointer

Flashpoint is about as defunct as they come, so it only gets provable
and major bug fixes until it gets ejected from the tree.

James