From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: TARUISI Hiroaki <taruishi.hiroak@jp.fujitsu.com>
Cc: michaelc@cs.wisc.edu, revers@redhat.com, linux-scsi@vger.kernel.org
Subject: Re: [RFC PATCH] SCSI: Correct UA being ignored when notifying of media-changed
Date: Tue, 09 Aug 2011 10:22:00 -0500 [thread overview]
Message-ID: <1312903320.13928.7.camel@mulgrave> (raw)
In-Reply-To: <4E40681F.2010306@jp.fujitsu.com>
On Tue, 2011-08-09 at 07:50 +0900, TARUISI Hiroaki wrote:
> Hi James,
>
> I posted a patch (as below) last year about this.
> http://www.kerneltrap.org/mailarchive/linux-scsi/2010/12/22/6887895
>
> I intended to distinguish UA caused by media change from UA caused by
> other reasons like resetting a device. First, it should be notified to upper
> layer driver, sr, but the other must be retried as scsi_error.c coded.
>
> At least SCSI driver should not squash all UAs, I think.
Well ... the spec says the device should stack UAs in this event.
However, I can totally believe that a broken CD would fail on this
front.
If Mike and Rob can verify that it's realy asc/ascq 0x28/0x0 that the CD
is emitting, I'd be happy to put the patch in (with a nice big comment
explaining what's being done and why over the if() check rather than
updating the global comment).
James
next prev parent reply other threads:[~2011-08-09 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 13:39 [RFC PATCH] SCSI: Correct UA being ignored when notifying of media-changed Rob Evers
2011-08-03 22:06 ` Mike Christie
2011-08-03 22:22 ` James Bottomley
2011-08-03 22:31 ` Mike Christie
2011-08-03 22:36 ` James Bottomley
2011-08-03 23:14 ` Mike Christie
2011-08-08 22:50 ` TARUISI Hiroaki
2011-08-09 15:22 ` James Bottomley [this message]
2011-08-11 11:25 ` [PATCH] SCSI: Prevent from retrying with expecting_cc_ua in case of disk change TARUISI Hiroaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312903320.13928.7.camel@mulgrave \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=revers@redhat.com \
--cc=taruishi.hiroak@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).