From: Hannes Reinecke <hare@suse.de>
To: James Bottomley <james.bottomley@parallels.com>
Cc: linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 4/7] scsi_dh_alua: always update TPGS status on activate
Date: Wed, 24 Aug 2011 10:51:16 +0200 [thread overview]
Message-ID: <1314175879-16565-5-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1314175879-16565-1-git-send-email-hare@suse.de>
When activating a patch we should always update the TPGS state
as it might have changed in between.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/scsi/device_handler/scsi_dh_alua.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
index 80c5cf3..f44dbf6 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -631,11 +631,9 @@ static int alua_activate(struct scsi_device *sdev,
struct alua_dh_data *h = get_alua_data(sdev);
int err = SCSI_DH_OK;
- if (h->group_id != -1) {
- err = alua_rtpg(sdev, h);
- if (err != SCSI_DH_OK)
- goto out;
- }
+ err = alua_rtpg(sdev, h);
+ if (err != SCSI_DH_OK)
+ goto out;
if (h->tpgs & TPGS_MODE_EXPLICIT &&
h->state != TPGS_STATE_OPTIMIZED &&
--
1.6.0.2
next prev parent reply other threads:[~2011-08-24 8:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 8:51 [PATCH 0/7] ALUA device handler update Hannes Reinecke
2011-08-24 8:51 ` [PATCH 1/7] scsi_dh_alua: Evaluate TPGS setting from inquiry data Hannes Reinecke
2011-08-24 8:51 ` [PATCH 2/7] scsi_dh: Fixup kernel-doc comments Hannes Reinecke
2011-08-24 8:51 ` [PATCH 3/7] scsi_dh: Implement match callback function Hannes Reinecke
2011-08-24 8:51 ` Hannes Reinecke [this message]
2011-08-24 8:51 ` [PATCH 5/7] scsi_dh: Check for sdev state in store_dh_state() Hannes Reinecke
2011-08-24 8:51 ` [PATCH 6/7] Erroneous TPG ID check in SCSI ALUA Handler Hannes Reinecke
2011-08-24 8:51 ` [PATCH 7/7] scsi_dh_alua: Decrease retry interval Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314175879-16565-5-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=james.bottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox