From: Tomas Henzl <thenzl@redhat.com>
To: linux-scsi@vger.kernel.org
Cc: steve.masters@lsi.com, michael.benz@lsi.com, aradford@gmail.com,
bo.yang@lsi.com, Tomas Henzl <thenzl@redhat.com>
Subject: [PATCH 1/2] megaraid_sas: Remove the shutdown_controller call
Date: Wed, 24 Aug 2011 17:35:29 +0200 [thread overview]
Message-ID: <1314200130-28890-2-git-send-email-thenzl@redhat.com> (raw)
In-Reply-To: <1314200130-28890-1-git-send-email-thenzl@redhat.com>
Remove the call to megasas_shutdown_controller in the megasas_shutdown.
It's unclear why it should be needed, flushing the cache and disabling ints
seems to be enough, because the system is likely going to be switched off
or restarted anyway. The main reason for removing this is a errant message
sent sometimes to the driver when the card is shut down.
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index a58f84a..14c33f6 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -4532,7 +4532,6 @@ static void megasas_shutdown(struct pci_dev *pdev)
struct megasas_instance *instance = pci_get_drvdata(pdev);
instance->unload = 1;
megasas_flush_cache(instance);
- megasas_shutdown_controller(instance, MR_DCMD_CTRL_SHUTDOWN);
instance->instancet->disable_intr(instance->reg_set);
free_irq(instance->msi_flag ? instance->msixentry.vector :
instance->pdev->irq, instance);
--
1.7.6
next prev parent reply other threads:[~2011-08-24 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 15:35 [PATCH 0/2] megaraid_sas: Fix an errant command from hw Tomas Henzl
2011-08-24 15:35 ` Tomas Henzl [this message]
2011-08-24 20:55 ` [PATCH 1/2] megaraid_sas: Remove the shutdown_controller call adam radford
2011-08-25 8:17 ` Tomas Henzl
2011-08-26 0:00 ` adam radford
2011-09-05 14:17 ` Tomas Henzl
2011-08-24 15:35 ` [PATCH 2/2] megaraid_sas: Initialize the cmd field to a known value Tomas Henzl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314200130-28890-2-git-send-email-thenzl@redhat.com \
--to=thenzl@redhat.com \
--cc=aradford@gmail.com \
--cc=bo.yang@lsi.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michael.benz@lsi.com \
--cc=steve.masters@lsi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).