linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Bhanu Prakash Gollapudi" <bprakash@broadcom.com>
To: JBottomley@parallels.com, linux-scsi@vger.kernel.org
Cc: michaelc@cs.wisc.edu, mchan@broadcom.com, nsujir@broadcom.com,
	Bhanu Prakash Gollapudi <bprakash@broadcom.com>
Subject: [PATCH 7/8] bnx2fc: Fix FW assert during RSCN stress tests
Date: Tue, 30 Aug 2011 15:54:53 -0700	[thread overview]
Message-ID: <1314744894-24710-8-git-send-email-bprakash@broadcom.com> (raw)
In-Reply-To: <1314744894-24710-1-git-send-email-bprakash@broadcom.com>

Firmware asserts when the same CQE is armed twice. This scenario happens during
RSCN stress tests as driver incorrects arms the CQ after the session is
offloaded.

Signed-off-by: Bhanu Prakash Gollapudi <bprakash@broadcom.com>
---
 drivers/scsi/bnx2fc/bnx2fc_tgt.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/bnx2fc/bnx2fc_tgt.c b/drivers/scsi/bnx2fc/bnx2fc_tgt.c
index 2138da9..c1800b5 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_tgt.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_tgt.c
@@ -133,9 +133,7 @@ retry_ofld:
 		printk(KERN_ERR PFX "map doorbell failed - no mem\n");
 		/* upload will take care of cleaning up sess resc */
 		lport->tt.rport_logoff(rdata);
-	} else
-		/* Arm CQ */
-		bnx2fc_arm_cq(tgt);
+	}
 	return;
 
 ofld_err:
-- 
1.7.0.6



  parent reply	other threads:[~2011-08-30 22:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-30 22:54 [PATCH 0/8] bnx2fc version 1.0.6 Bhanu Prakash Gollapudi
2011-08-30 22:54 ` [PATCH 1/8] bnx2fc: Reset max receive frame size during link up Bhanu Prakash Gollapudi
2011-08-30 22:54 ` [PATCH 2/8] bnx2fc: Send solicitation only after vlan discovery is complete Bhanu Prakash Gollapudi
2011-08-30 22:54 ` [PATCH 3/8] bnx2fc: No abort issued for REC when it times out Bhanu Prakash Gollapudi
2011-08-30 22:54 ` [PATCH 4/8] bnx2fc: Validate vlan id in NETDEV_UNREGISTER handler Bhanu Prakash Gollapudi
2011-08-30 22:54 ` [PATCH 5/8] bnx2fc: Avoid calling bnx2fc_if_destroy with unnecessary locks Bhanu Prakash Gollapudi
2011-08-30 22:54 ` [PATCH 6/8] bnx2fc: Fix panic caused because of incorrect errror handling in create() Bhanu Prakash Gollapudi
2011-08-30 22:54 ` Bhanu Prakash Gollapudi [this message]
2011-08-30 22:54 ` [PATCH 8/8] bnx2fc: Bumped version to 1.0.6 Bhanu Prakash Gollapudi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1314744894-24710-8-git-send-email-bprakash@broadcom.com \
    --to=bprakash@broadcom.com \
    --cc=JBottomley@parallels.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mchan@broadcom.com \
    --cc=michaelc@cs.wisc.edu \
    --cc=nsujir@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).