Re: [PATCH] [SCSI] libsas panic when single phy disabled on a wide port

Dan Williams
2011-10-04T23:38:22Z

On Tue, Oct 4, 2011 at 4:30 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> That initially looked convincing... but on closer look
> sas_port_delete_phy is reducing the number of phys in the transport
> class representation of the port (struct sas_port), while the
> decrement that sas_deform port is doing is operating the on the
> host-local port (struct asd_sas_port).

This confusion happens so often for me as well. Maybe it is time to
rename these structures and local variable instances, something like:

asd_sas_port --> host_sas_port
asd_sas_phy --> host_sas_phy

...and:

port --> hport
phy --> hphy

...for the local variable instances.

??