From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
Cc: stephenmcameron@gmail.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
mikem@beardog.cce.hp.com
Subject: Re: [PATCH 4/5] hpsa: fix potential array overflow in hpsa_update_scsi_devices
Date: Sun, 30 Oct 2011 14:16:22 +0400 [thread overview]
Message-ID: <1319969782.5215.23.camel@dabdike> (raw)
In-Reply-To: <20111026212112.15570.72971.stgit@beardog.cce.hp.com>
On Wed, 2011-10-26 at 16:21 -0500, Stephen M. Cameron wrote:
> From: Scott Teel <scott.teel@hp.com>
>
> The currentsd[] array in hpsa_update_scsi_devices had room for
> 256 devices. The code was iterating over however many physical
> and logical devices plus an additional number of possible external
> MSA2XXX controllers, which together could potentially exceed 256.
>
> We increased the size of the currentsd array to 1024 + 1024 + 32 + 1
> elements to reflect a reasonable maximum possible number of devices
> which might be encountered. We also don't just walk off the end
> of the array if the array controller reports more devices than we
> are prepared to handle, we just ignore the excessive devices.
>
> Signed-off-by: Scott Teel <scott.teel@hp.com>
> Acked-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
This should be Signed-off-by not Acked-by. The reason is that the
signoffs track whose hands the patch passes through. If you send
Scott's patch to me, it must have your signoff. If Scott sends the
patch directly to me and then you OK it on the list, then I'll add
Acked-by. I've assumed your acquiescence to correcting this in my tree.
James
next prev parent reply other threads:[~2011-10-30 10:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 21:20 [PATCH 0/5] hpsa: driver updates, Oct 25, 2011 Stephen M. Cameron
2011-10-26 21:20 ` [PATCH 1/5] hpsa: set max sectors instead of taking the default Stephen M. Cameron
2011-10-26 21:20 ` [PATCH 2/5] hpsa: remove unused busy_initializing and busy_scanning Stephen M. Cameron
2011-10-26 21:21 ` [PATCH 3/5] hpsa: rename HPSA_MAX_SCSI_DEVS_PER_HBA Stephen M. Cameron
2011-10-26 21:21 ` [PATCH 4/5] hpsa: fix potential array overflow in hpsa_update_scsi_devices Stephen M. Cameron
2011-10-30 10:16 ` James Bottomley [this message]
2011-10-31 14:36 ` scameron
2011-10-26 21:21 ` [PATCH 5/5] hpsa: fix flush cache transfer length Stephen M. Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319969782.5215.23.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mikem@beardog.cce.hp.com \
--cc=scameron@beardog.cce.hp.com \
--cc=stephenmcameron@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox