linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lin Ming <ming.m.lin@intel.com>
To: linux-kernel@vger.kernel.org
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-pm@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
	Jeff Garzik <jgarzik@pobox.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	James Bottomley <JBottomley@parallels.com>,
	Tejun Heo <tj@kernel.org>, Huang Ying <ying.huang@intel.com>,
	Zhang Rui <rui.zhang@intel.com>
Subject: [PATCH v2 0/4] ata port runtime power management support
Date: Thu, 10 Nov 2011 14:22:42 +0800	[thread overview]
Message-ID: <1320906166-15459-1-git-send-email-ming.m.lin@intel.com> (raw)

Hi, all

These 4 patches add ata port runtime pm support.

v1:
https://lkml.org/lkml/2011/11/2/23

v2 is totally different than v1.

v1 performed ata port runtime pm through scsi layer.
Added hook to scsi host runtime suspend/resume code.

I realized that this is not the natural way to do ata port runtime pm.
It does not deal with the races with ata port system suspend/resume.

With v2, ata port is made to be parent device of scsi host.

Currently, the device tree of ata port and scsi host looks as below,

        /sys/devices/pci0000:00/0000:00:1f.2    (ahci controller)
        |-- ata1                                (ata port)
        |-- host0                               (scsi host)
           |-- target0:0:0                      (scsi target)
               |-- 0:0:0:0                      (disk)

v2 changes it to:

        /sys/devices/pci0000:00/0000:00:1f.2    (ahci controller)
        |-- ata1                                (ata port)
            |-- host0                           (scsi host)
                |-- target0:0:0                 (scsi target)
                    |-- 0:0:0:0                 (disk)

So ata port runtime PM will happen as:

disk suspend --> scsi target suspend --> scsi host suspend --> ata port
suspend.

This is much cleaner and natural.

Lin Ming (4):
      ata: make ata port as parent device of scsi host
      scsi: add flag to skip the runtime PM calls on host in EH
      ata: add ata port system PM callbacks
      ata: add ata port runtime PM callbacks

 drivers/ata/libata-core.c      |  158 ++++++++++++++++++++++------------------
 drivers/ata/libata-scsi.c      |    3 +-
 drivers/ata/libata-transport.c |    5 +
 drivers/ata/libata.h           |    1 +
 drivers/scsi/scsi_error.c      |    5 +-
 include/scsi/scsi_host.h       |    3 +
 6 files changed, 102 insertions(+), 73 deletions(-)

Thanks for any comment.
Lin Min

             reply	other threads:[~2011-11-10  6:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-10  6:22 Lin Ming [this message]
2011-11-10  6:22 ` [PATCH v2 1/4] ata: make ata port as parent device of scsi host Lin Ming
2011-11-10  6:22 ` [PATCH v2 2/4] scsi: add flag to skip the runtime PM calls on host in EH Lin Ming
2011-11-10  6:22 ` [PATCH v2 3/4] ata: add ata port system PM callbacks Lin Ming
2011-11-10  6:22 ` [PATCH v2 4/4] ata: add ata port runtime " Lin Ming
2011-11-10 15:40   ` Alan Stern
2011-11-10 15:45     ` Tejun Heo
     [not found]   ` <CAF1ivSZ3rnb90u6LHXfWCBW-6mtfmWYjj1xXfABmm=uNVbomRw@mail.gmail.com>
2011-11-14  5:14     ` Lin Ming
2011-11-14 15:31       ` Alan Stern
2011-11-15  8:51         ` Lin Ming
2011-11-15 14:54           ` Tejun Heo
2011-11-15 16:08             ` Alan Stern
2011-11-16 13:14               ` Lin Ming
2011-11-16 15:42                 ` Alan Stern
2011-11-10 15:30 ` [PATCH v2 0/4] ata port runtime power management support Tejun Heo
2011-11-10 15:31   ` Tejun Heo
2011-11-11  2:25     ` Lin Ming
2011-11-10 16:02   ` Kay Sievers
2011-11-11  2:33   ` Lin Ming
2011-11-10 15:30 ` Alan Stern
2011-11-10 15:37   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320906166-15459-1-git-send-email-ming.m.lin@intel.com \
    --to=ming.m.lin@intel.com \
    --cc=JBottomley@parallels.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=rui.zhang@intel.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tj@kernel.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).