From: Richard Weinberger <richard@nod.at>
To: JBottomley@parallels.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Richard Weinberger <richard@nod.at>
Subject: [PATCH] scsi_dh: Fix return value of scsi_dh_attach()
Date: Fri, 18 Nov 2011 00:34:24 +0100 [thread overview]
Message-ID: <1321572864-23628-1-git-send-email-richard@nod.at> (raw)
scsi_dh_attach() should return a negative value on error.
Signed-off-by: Richard Weinberger <richard@nod.at>
---
include/scsi/scsi_dh.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/scsi/scsi_dh.h b/include/scsi/scsi_dh.h
index e3f2db2..e07ab10 100644
--- a/include/scsi/scsi_dh.h
+++ b/include/scsi/scsi_dh.h
@@ -74,7 +74,7 @@ static inline int scsi_dh_handler_exist(const char *name)
}
static inline int scsi_dh_attach(struct request_queue *req, const char *name)
{
- return SCSI_DH_NOSYS;
+ return -SCSI_DH_NOSYS;
}
static inline void scsi_dh_detach(struct request_queue *q)
{
--
1.7.7.3
next reply other threads:[~2011-11-17 23:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 23:34 Richard Weinberger [this message]
2011-12-18 14:43 ` [PATCH] scsi_dh: Fix return value of scsi_dh_attach() Richard Weinberger
2011-12-18 14:45 ` James Bottomley
2011-12-18 14:53 ` Richard Weinberger
2011-12-19 11:59 ` Hannes Reinecke
2011-12-19 12:40 ` Richard Weinberger
-- strict thread matches above, loose matches on Subject: below --
2011-12-19 12:05 Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321572864-23628-1-git-send-email-richard@nod.at \
--to=richard@nod.at \
--cc=JBottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).