From: Richard Weinberger <richard@nod.at>
To: JBottomley@parallels.com
Cc: Babu.moger@netapp.com, Somasundaram.Krishnasamy@lsi.com,
yanling.qi@lsi.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, Richard Weinberger <richard@nod.at>
Subject: [PATCH] scsi_dh_rdac: Fix error path
Date: Fri, 18 Nov 2011 01:44:27 +0100 [thread overview]
Message-ID: <1321577067-26332-1-git-send-email-richard@nod.at> (raw)
If create_singlethread_workqueue() failes, rdac_init should fail too.
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/scsi/device_handler/scsi_dh_rdac.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c b/drivers/scsi/device_handler/scsi_dh_rdac.c
index 1d31279..2802394 100644
--- a/drivers/scsi/device_handler/scsi_dh_rdac.c
+++ b/drivers/scsi/device_handler/scsi_dh_rdac.c
@@ -934,6 +934,8 @@ static int __init rdac_init(void)
if (!kmpath_rdacd) {
scsi_unregister_device_handler(&rdac_dh);
printk(KERN_ERR "kmpath_rdacd creation failed.\n");
+
+ r = -EINVAL;
}
done:
return r;
--
1.7.7.3
next reply other threads:[~2011-11-18 0:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 0:44 Richard Weinberger [this message]
2011-11-18 14:34 ` [PATCH] scsi_dh_rdac: Fix error path Moger, Babu
2011-12-18 14:42 ` Richard Weinberger
2012-01-09 22:13 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321577067-26332-1-git-send-email-richard@nod.at \
--to=richard@nod.at \
--cc=Babu.moger@netapp.com \
--cc=JBottomley@parallels.com \
--cc=Somasundaram.Krishnasamy@lsi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=yanling.qi@lsi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).