From: Lin Ming <ming.m.lin@intel.com>
To: Jeff Garzik <jgarzik@pobox.com>,
James Bottomley <JBottomley@parallels.com>,
Alan Stern <stern@rowland.harvard.edu>, Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Huang Ying <ying.huang@intel.com>,
Zhang Rui <rui.zhang@intel.com>
Subject: [PATCH v4 1/6] ata: make ata port as parent device of scsi host
Date: Mon, 28 Nov 2011 09:15:45 +0800 [thread overview]
Message-ID: <1322442950-16268-2-git-send-email-ming.m.lin@intel.com> (raw)
In-Reply-To: <1322442950-16268-1-git-send-email-ming.m.lin@intel.com>
Currently, the device tree of ata port and scsi host looks as below,
/sys/devices/pci0000:00/0000:00:1f.2 (ahci controller)
|-- ata1 (ata port)
|-- host0 (scsi host)
|-- target0:0:0 (scsi target)
|-- 0:0:0:0 (disk)
This patch makes ata port as parent device of scsi host, then it becomes
/sys/devices/pci0000:00/0000:00:1f.2 (ahci controller)
|-- ata1 (ata port)
|-- host0 (scsi host)
|-- target0:0:0 (scsi target)
|-- 0:0:0:0 (disk)
With this change, the ata port runtime PM is easier.
For example, the ata port runtime suspend will happen as,
disk suspend --> scsi target suspend --> scsi host suspend --> ata port
suspend.
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
---
drivers/ata/libata-scsi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 2a5412e..7ae1e77 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -3398,7 +3398,7 @@ int ata_scsi_add_hosts(struct ata_host *host, struct scsi_host_template *sht)
*/
shost->max_host_blocked = 1;
- rc = scsi_add_host(ap->scsi_host, ap->host->dev);
+ rc = scsi_add_host(ap->scsi_host, &ap->tdev);
if (rc)
goto err_add;
}
--
1.7.2.5
next prev parent reply other threads:[~2011-11-28 1:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 1:15 [PATCH v4 0/6] ata port runtime power management support Lin Ming
2011-11-28 1:15 ` Lin Ming [this message]
2011-11-28 1:15 ` [PATCH v4 2/6] [SCSI] add flag to skip the runtime PM calls on the host Lin Ming
2011-11-28 1:15 ` [PATCH v4 3/6] [SCSI] check runtime PM status in system PM Lin Ming
2011-11-28 1:15 ` [PATCH v4 4/6] [SCSI] sd: check runtime PM status in sd_shutdown Lin Ming
2011-11-28 1:15 ` [PATCH v4 5/6] ata: add ata port system PM callbacks Lin Ming
2011-11-28 1:15 ` [PATCH v4 6/6] ata: add ata port runtime " Lin Ming
2011-11-28 10:13 ` Sergei Shtylyov
2011-11-28 13:50 ` Lin Ming
2011-12-01 14:09 ` [PATCH v4 0/6] ata port runtime power management support Lin Ming
2011-12-01 14:20 ` Jeff Garzik
2011-12-01 14:28 ` Lin Ming
2011-12-01 15:30 ` James Bottomley
2011-12-02 5:35 ` Lin Ming
2011-12-02 15:29 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322442950-16268-2-git-send-email-ming.m.lin@intel.com \
--to=ming.m.lin@intel.com \
--cc=JBottomley@parallels.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=rui.zhang@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).