From: taco <tacoee@gmail.com>
To: axboe@kernel.dk, linux-kernel@vger.kernel.org
Cc: taco <tacoee@gmail.com>, linux-scsi@vger.kernel.org
Subject: [PATCH] block: Needn't read the size of device or partition again
Date: Sun, 11 Dec 2011 21:10:47 +0800 [thread overview]
Message-ID: <1323609047-12242-1-git-send-email-tacoee@gmail.com> (raw)
In-Reply-To: <yes>
It is not necessary to invoke i_size_read to get the size of device or
partition again, due to did it before.i_size_read maybe need to abtain
lock or disable preempt.
Signed-off-by: taco <tacoee@gmail.com>
---
block/blk-core.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index ea70e6c..3aa3fc3 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -1423,7 +1423,7 @@ static inline void blk_partition_remap(struct bio *bio)
}
}
-static void handle_bad_sector(struct bio *bio)
+static void handle_bad_sector(struct bio *bio, sector_t maxsector)
{
char b[BDEVNAME_SIZE];
@@ -1432,7 +1432,7 @@ static void handle_bad_sector(struct bio *bio)
bdevname(bio->bi_bdev, b),
bio->bi_rw,
(unsigned long long)bio->bi_sector + bio_sectors(bio),
- (long long)(i_size_read(bio->bi_bdev->bd_inode) >> 9));
+ (long long)maxsector);
set_bit(BIO_EOF, &bio->bi_flags);
}
@@ -1493,7 +1493,7 @@ static inline int bio_check_eod(struct bio *bio, unsigned int nr_sectors)
* without checking the size of the device, e.g., when
* mounting a device.
*/
- handle_bad_sector(bio);
+ handle_bad_sector(bio, maxsector);
return 1;
}
}
--
1.7.5.4
next parent reply other threads:[~2011-12-11 13:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <yes>
2011-12-11 13:10 ` taco [this message]
2014-08-12 6:40 ` [PATCH v3] uas: replace WARN_ON_ONCE() with lockdep_assert_held() Sanjeev Sharma
2014-08-12 6:28 ` Hans de Goede
2014-08-12 6:37 ` Sharma, Sanjeev
2014-08-19 6:33 ` Sharma, Sanjeev
2014-08-19 9:30 ` gregkh
[not found] ` <20140819093047.GA991-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2014-08-19 9:38 ` Sharma, Sanjeev
2014-09-04 7:06 ` Sharma, Sanjeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323609047-12242-1-git-send-email-tacoee@gmail.com \
--to=tacoee@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox