From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH 12/14] qla2xxx: Correct fc_host port_state display. Date: Mon, 12 Dec 2011 12:50:48 +0400 Message-ID: <1323679848.1512.30.camel@dabdike> References: <1321635742-16426-1-git-send-email-chad.dupuis@qlogic.com> <1321635742-16426-13-git-send-email-chad.dupuis@qlogic.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from bedivere.hansenpartnership.com ([66.63.167.143]:38271 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750887Ab1LLIuw (ORCPT ); Mon, 12 Dec 2011 03:50:52 -0500 In-Reply-To: <1321635742-16426-13-git-send-email-chad.dupuis@qlogic.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Chad Dupuis Cc: giridhar.malavali@qlogic.com, andrew.vasquez@qlogic.com, linux-scsi@vger.kernel.org On Fri, 2011-11-18 at 09:02 -0800, Chad Dupuis wrote: > From: Saurav Kashyap > > Add more fine grain parsing of vha->loop_state to export a more accurate > fc_host port_state. > > Signed-off-by: Saurav Kashyap > Signed-off-by: Chad Dupuis Could you pass your patches through checkpatch.pl, please? There are 17 errors in here including spaces instead of tabs and a missing space before the opening bracket of an if clause. I fixed it up this time. James > drivers/scsi/qla2xxx/qla_attr.c | 27 +++++++++++++++++++++++---- > 1 files changed, 23 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c > index ac326c4..7acd442 100644 > --- a/drivers/scsi/qla2xxx/qla_attr.c > +++ b/drivers/scsi/qla2xxx/qla_attr.c > @@ -1762,12 +1762,31 @@ qla2x00_get_host_port_state(struct Scsi_Host *shost) > scsi_qla_host_t *vha = shost_priv(shost); > struct scsi_qla_host *base_vha = pci_get_drvdata(vha->hw->pdev); > > - if (!base_vha->flags.online) > + if (!base_vha->flags.online) { > fc_host_port_state(shost) = FC_PORTSTATE_OFFLINE; > - else if (atomic_read(&base_vha->loop_state) == LOOP_TIMEOUT) > - fc_host_port_state(shost) = FC_PORTSTATE_UNKNOWN; > - else > + return; > + } > + > + switch (atomic_read(&base_vha->loop_state)) { > + case LOOP_UPDATE: > + fc_host_port_state(shost) = FC_PORTSTATE_DIAGNOSTICS; > + break; > + case LOOP_DOWN: > + if(test_bit(LOOP_RESYNC_NEEDED, &base_vha->dpc_flags)) > + fc_host_port_state(shost) = FC_PORTSTATE_DIAGNOSTICS; > + else > + fc_host_port_state(shost) = FC_PORTSTATE_LINKDOWN; > + break; > + case LOOP_DEAD: > + fc_host_port_state(shost) = FC_PORTSTATE_LINKDOWN; > + break; > + case LOOP_READY: > fc_host_port_state(shost) = FC_PORTSTATE_ONLINE; > + break; > + default: > + fc_host_port_state(shost) = FC_PORTSTATE_UNKNOWN; > + break; > + } > } > > static int