From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Dillow Subject: Re: [PATCH 13/14] ib_srp: Implement transport layer ping Date: Wed, 28 Dec 2011 18:53:48 -0500 Message-ID: <1325116430.3004.36.camel@obelisk.thedillows.org> References: <201112011954.25811.bvanassche@acm.org> <201112012011.45444.bvanassche@acm.org> <1324255806.17849.68.camel@obelisk.thedillows.org> <1324333931.7043.52.camel@lap75545.ornl.gov> <1324436736.7621.38.camel@obelisk.thedillows.org> <1324679698.3004.12.camel@obelisk.thedillows.org> <4EF50705.7090200@cs.wisc.edu> <1324757240.3004.28.camel@obelisk.thedillows.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from matrix.voodoobox.net ([75.127.97.206]:37865 "EHLO matrix.voodoobox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754008Ab1L1XyM (ORCPT ); Wed, 28 Dec 2011 18:54:12 -0500 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Bart Van Assche Cc: Mike Christie , "linux-rdma@vger.kernel.org" , "linux-scsi@vger.kernel.org" , Roland Dreier , Fujita Tomonori , Brian King On Mon, 2011-12-26 at 19:39 +0000, Bart Van Assche wrote: > On Sat, Dec 24, 2011 at 8:07 PM, David Dillow wrote: > > This says to me that SRP should use the dev_loss_tmo semantics, though > > the naming of fast_io_fail vs replacement_timeout is a bit more of a > > question than I thought. I tend to think of SRP more in terms of FC than > > iSCSI, so I still prefer the former, but perhaps not as strongly now. > > Do we need dev_loss_tmo functionality ? Since multipathd switches over > if the active path is in the blocked state, the posted patch set > already provides a way to make multipathd switch over if communication > is lost. I think so. multipathd isn't the only use case, though I think we need to reorganize the SRP device model to fully take advantage of dev_loss_tmo -- but that can come later. I'd like to see dev_loss_tmo take the place of max_reconnects to give admins an easy way to set a maximum time. -- Dave Dillow National Center for Computational Science Oak Ridge National Laboratory (865) 241-6602 office