From: Joe Perches <joe@perches.com>
To: Bhanu Prakash Gollapudi <bprakash@broadcom.com>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bnx2fc: Reduce object size by consolidating formats
Date: Tue, 03 Jan 2012 10:42:56 -0800 [thread overview]
Message-ID: <1325616176.21062.4.camel@joe2Laptop> (raw)
In-Reply-To: <4ECC5097.2050908@broadcom.com>
On Tue, 2011-11-22 at 17:47 -0800, Bhanu Prakash Gollapudi wrote:
> On 11/19/2011 1:35 PM, Joe Perches wrote:
> > Deduplication of formats and consolidating tests
> > makes the object much smaller.
> >
> > Add bnx2fc_debug.c, add functions for a few logging
> > functions (BNX2FC_IO_DBG, BNX2FC_TGT_DBG, BNX2FC_HBA_DBG).
> > Use printf extension %pV.
> > Add and use pr_fmt and pr_<level>.
> > Move the debug #include below structure definitions.
> >
> > $ size drivers/scsi/bnx2fc/built-in.o*
> > text data bss dec hex filename
> > 101563 1165 24976 127704 1f2d8 drivers/scsi/bnx2fc/built-in.o.new
> > 138473 1109 33400 172982 2a3b6 drivers/scsi/bnx2fc/built-in.o.old
> >
> > Signed-off-by: Joe Perches<joe@perches.com>
> Thanks Joe.
>
> Acked-by: Bhanu Prakash Gollapudi <bprakash@broadcom.com>
Still unmerged after 6 weeks. What's happening with this?
prev parent reply other threads:[~2012-01-03 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-19 21:35 [PATCH] bnx2fc: Reduce object size by consolidating formats Joe Perches
2011-11-23 1:47 ` Bhanu Prakash Gollapudi
2012-01-03 18:42 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325616176.21062.4.camel@joe2Laptop \
--to=joe@perches.com \
--cc=JBottomley@parallels.com \
--cc=bprakash@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox