From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Cc: Andrew Vasquez <andrew.vasquez@qlogic.com>,
Giridhar Malavali <giridhar.malavali@qlogic.com>,
Arun Easi <arun.easi@qlogic.com>, Christoph Hellwig <hch@lst.de>,
Roland Dreier <roland@purestorage.com>,
Madhuranath Iyengar <mni@risingtidesystems.com>,
Nicholas Bellinger <nab@linux-iscsi.org>
Subject: [PATCH 0/4] target/tcm_qla2xxx: Add TMR_ABORT_TASK support
Date: Mon, 13 Feb 2012 11:42:23 +0000 [thread overview]
Message-ID: <1329133347-13359-1-git-send-email-nab@linux-iscsi.org> (raw)
From: Nicholas Bellinger <nab@linux-iscsi.org>
Hi folks,
The following series adds explict TMR_ABORT_TASK support using session
command list descriptors for target_submit_cmd() fabric module users.
The logic performs explict abort using tmr->ref_task_tag for outstanding
descriptors have not been set CMD_T_COMPLETE in transport_complete_task()
during backend I/O completion. It also cancels se_cmd->work and wait for
backing I/O to complete before attempting to send SAM_STAT_TASK_ABORTED
and perform necessary target_put_sess_cmd() to drop outstanding cmd_kref
references.
So far this has been tested with tcm_qla2xxx using target-core debug code
to simulate delayed execution of a referenced tag descriptor in the
following locations:
- Before execution of tasks in transport_generic_new_cmd()
- Before completion of tasks in transport_complete_task()
- After completion of tasks in transport_complete_task()
The code can use some more testing and review, but so far these changes
with simulated I/O delays are generating SAM_STAT_TASK_ABORTED status for
the aborted tag, or failing with TMR_TASK_DOES_NOT_EXIST as expected..
Please have a look,
--nab
Nicholas Bellinger (4):
target: Add SCF_ACK_KREF flag for acknowledgement kref
target: Make target_release_cmd_kref release on empty list
target: Add TMR_ABORT_TASK task management support
qla_target/tcm_qla2xxx: Fix TMR_ABORT_TASK with target mode usage
drivers/scsi/qla2xxx/qla_target.c | 15 +++----
drivers/scsi/qla2xxx/qla_target.h | 2 +-
drivers/scsi/qla2xxx/tcm_qla2xxx.c | 6 ++-
drivers/scsi/qla2xxx/tcm_qla2xxx.h | 3 +-
drivers/target/target_core_internal.h | 2 +
drivers/target/target_core_tmr.c | 64 ++++++++++++++++++++++++++++++++
drivers/target/target_core_transport.c | 26 ++++++++----
include/target/target_core_base.h | 3 +-
8 files changed, 100 insertions(+), 21 deletions(-)
--
1.7.2.5
next reply other threads:[~2012-02-13 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-13 11:42 Nicholas A. Bellinger [this message]
2012-02-13 11:42 ` [PATCH 1/4] target: Add SCF_ACK_KREF flag for acknowledgement kref Nicholas A. Bellinger
2012-02-13 11:42 ` [PATCH 2/4] target: Make target_release_cmd_kref release on empty list Nicholas A. Bellinger
2012-02-13 11:42 ` [PATCH 3/4] target: Add TMR_ABORT_TASK task management support Nicholas A. Bellinger
2012-02-13 11:42 ` [PATCH 4/4] qla_target/tcm_qla2xxx: Fix TMR_ABORT_TASK with target mode usage Nicholas A. Bellinger
2012-02-17 1:35 ` [PATCH 0/4] target/tcm_qla2xxx: Add TMR_ABORT_TASK support Andy Grover
2012-02-17 8:13 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329133347-13359-1-git-send-email-nab@linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=andrew.vasquez@qlogic.com \
--cc=arun.easi@qlogic.com \
--cc=giridhar.malavali@qlogic.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=mni@risingtidesystems.com \
--cc=roland@purestorage.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).