From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhang Rui Subject: Re: [RFC PATCH 4/6] PM / Runtime: Introduce flag can_power_off Date: Tue, 14 Feb 2012 14:17:23 +0800 Message-ID: <1329200243.19384.16.camel@rui.sh.intel.com> References: <201202132038.12927.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <201202132038.12927.rjw@sisk.pl> Sender: linux-ide-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: Alan Stern , Lin Ming , Jeff Garzik , Tejun Heo , Len Brown , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On =E4=B8=80, 2012-02-13 at 20:38 +0100, Rafael J. Wysocki wrote: > On Monday, February 13, 2012, Alan Stern wrote: > > On Mon, 13 Feb 2012, Lin Ming wrote: > >=20 > > > From: Zhang Rui > > >=20 > > > Introduce flag can_power_off in device structure to support runti= me > > > power off/on. > > >=20 > > > Note that, for a specific device driver, > > > "support runtime power off/on" means that the driver .runtime_sus= pend > > > callback needs to > > > 1) save all the context so that it can restore the device back to= the previous > > > working state after powered on. > > > 2) set can_power_off flag to tell the driver model that it's read= y for power off. > > >=20 > > > The following example shows how this works. > > >=20 > > > device A > > > |---------| > > > v v > > > device B device C > > >=20 > > > A is the parent of device B and device C, and device A/B/C shares= the > > > same power logic > > > (Only device A knows how to turn on/off the power). > > >=20 > > > In order to power off A, B, C at runtime, > > > 1) device B and device C should support runtime power off > > > (runtime suspended with can_power_off flag set) > > > 2) pm idle request for device A is fired by runtime PM core. > > > 3) in device A .runtime_suspend callback, it tries to set can_pow= er_off flag. > > > 4) if succeed, it means all its children have been ready for powe= r off > > > and it can turn off the power at any time. > > > 5) if failed, it means at least one of its children does not supp= ort runtime > > > power off, thus the power can not be turned off. > >=20 > > I'm not sure if this is really the right approach. What you're try= ing=20 > > to do is implement two different low-power states, basically D3hot = and=20 > > D3cold. Currently the runtime PM core doesn't support such things;= all=20 > > it knows about is low power and full power. >=20 > I'd rather say all it knows about is "suspended" and "active", which = mean > "the device is not processing I/O" and "the device may be processing = I/O", > respectively. A "suspended" device may or may not be in a low-power = state, > but the runtime PM core doesn't care about that. >=20 yes, I know that. > > Before doing an ad-hoc implementation, it would be best to step bac= k > > and think about other subsystems. Other sorts of devices may well = have > > multiple low-power states. What's the best way for this to be > > supported by the PM core? >=20 > Well, I honestly don't think there's any way they all can be covered = at the > same time and that's why we chose to support only "suspended" and "ac= tive" > as defined above. > The handling of multiple low-power states must be > implemented outside of the runtime PM core (like in the PCI core, for= example). Surely I'd prefer to implement it in the bus code, :), but the problem is that several buses maybe involved at the same time. Let's take ZPODD for example, ZPODD is attached to a SATA port. Only SATA port knows that it can be runtime powered off, because its ACPI node has _PR3._OFF. But when ATA layer code tries to put SATA port to D3_COLD at runtime,it must make sure all the devices/drivers in the same power domain are ready for power off, and in this case, we need to get this info from SCSI layer. thanks, rui