From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Bart Van Assche <bvanassche@acm.org>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/3] iscsi: fix setting of pid from netlink skb
Date: Sat, 18 Feb 2012 16:06:00 -0600 [thread overview]
Message-ID: <1329602760.2862.35.camel@dabdike> (raw)
In-Reply-To: <4F225446.1000709@cs.wisc.edu>
On Fri, 2012-01-27 at 01:37 -0600, Mike Christie wrote:
> On 01/27/2012 01:04 AM, Bart Van Assche wrote:
> > On Fri, Jan 27, 2012 at 4:13 AM, <michaelc@cs.wisc.edu> wrote:
> >> NETLINK_CREDS's pid now returns 0, so I guess we are supposed to
> >> be using NETLINK_CB. This changed while the patch to export the
> >> pid was getting merged upstream, so it was not noticed until both
> >> the network and iscsi changes were in the same tree.
> >>
> >> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
> >
> > If my analysis is correct this patch has not only to be applied on the
> > master branch but also on kernel 3.2. Shouldn't "Cc:
> > stable@vger.kernel.org #3.2" be added here ? See also
> > http://www.spinics.net/lists/netdev/msg185565.html.
> >
>
> The iscsi code that uses the pid just got merged in the 3.3 feature
> window, so no need.
>
> Also for stable, I think we normally just tell James it should go in
> stable and then he does some magic. In the past, when he knows it should
> go there, when the patch gets merged and sent upstream the stable people
> were notified automagically.
That's the
cc: stable@kernel.org
tag in the commit ... but don't necessarily rely on me to add this. I
do add it in a few cases, but I do need people to indicate should go to
stable by adding the cc: in their commit, otherwise I have to guess.
James
next prev parent reply other threads:[~2012-02-18 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 3:13 iscsi bug fixes for 3.3 michaelc
2012-01-27 3:13 ` [PATCH 1/3] iscsi: fix setting of pid from netlink skb michaelc
2012-01-27 7:04 ` Bart Van Assche
2012-01-27 7:37 ` Mike Christie
2012-02-18 22:06 ` James Bottomley [this message]
2012-01-27 3:13 ` [PATCH 2/3] libiscsi_tcp: fix max_r2t manipulation michaelc
2012-01-27 3:13 ` [PATCH 3/3] libiscsi: fix cmd timeout/completion race michaelc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329602760.2862.35.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox