linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roland Dreier <roland@kernel.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: [PATCH] qla2xxx: Fix sign of FCP_RESID field for status with RESID_OVER
Date: Thu, 23 Feb 2012 12:14:02 -0800	[thread overview]
Message-ID: <1330028042-15599-1-git-send-email-roland@kernel.org> (raw)

From: Roland Dreier <roland@purestorage.com>

We don't need to change the sign of our prm->residual field; the target
core sets a flag to distinguish overflow and underflow, but
se_cmd->residual_count is always positive.  The existing code seems to
be a carryover from the port from scst, which uses the sign of the
residual field to distinguish overflow and underflow.

Signed-off-by: Roland Dreier <roland@purestorage.com>
---
 drivers/scsi/qla2xxx/qla_target.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 9282014..b12fb84 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -1808,7 +1808,6 @@ static int qla_tgt_pre_xmit_response(struct qla_tgt_cmd *cmd, struct qla_tgt_prm
 			se_cmd->t_task_cdb ? se_cmd->t_task_cdb[0] : 0,
 			cmd->bufflen, prm->rq_result);
 		prm->rq_result |= SS_RESIDUAL_OVER;
-		prm->residual = -prm->residual;
 	}
 
 	if (xmit_type & QLA_TGT_XMIT_STATUS) {
-- 
1.7.9


             reply	other threads:[~2012-02-23 20:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-23 20:14 Roland Dreier [this message]
2012-02-25  1:11 ` [PATCH] qla2xxx: Fix sign of FCP_RESID field for status with RESID_OVER Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330028042-15599-1-git-send-email-roland@kernel.org \
    --to=roland@kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).