* [PATCH] qla2xxx: Fix sign of FCP_RESID field for status with RESID_OVER
@ 2012-02-23 20:14 Roland Dreier
2012-02-25 1:11 ` Nicholas A. Bellinger
0 siblings, 1 reply; 2+ messages in thread
From: Roland Dreier @ 2012-02-23 20:14 UTC (permalink / raw)
To: Nicholas A. Bellinger; +Cc: linux-scsi, target-devel
From: Roland Dreier <roland@purestorage.com>
We don't need to change the sign of our prm->residual field; the target
core sets a flag to distinguish overflow and underflow, but
se_cmd->residual_count is always positive. The existing code seems to
be a carryover from the port from scst, which uses the sign of the
residual field to distinguish overflow and underflow.
Signed-off-by: Roland Dreier <roland@purestorage.com>
---
drivers/scsi/qla2xxx/qla_target.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 9282014..b12fb84 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -1808,7 +1808,6 @@ static int qla_tgt_pre_xmit_response(struct qla_tgt_cmd *cmd, struct qla_tgt_prm
se_cmd->t_task_cdb ? se_cmd->t_task_cdb[0] : 0,
cmd->bufflen, prm->rq_result);
prm->rq_result |= SS_RESIDUAL_OVER;
- prm->residual = -prm->residual;
}
if (xmit_type & QLA_TGT_XMIT_STATUS) {
--
1.7.9
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] qla2xxx: Fix sign of FCP_RESID field for status with RESID_OVER
2012-02-23 20:14 [PATCH] qla2xxx: Fix sign of FCP_RESID field for status with RESID_OVER Roland Dreier
@ 2012-02-25 1:11 ` Nicholas A. Bellinger
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2012-02-25 1:11 UTC (permalink / raw)
To: Roland Dreier; +Cc: linux-scsi, target-devel
On Thu, 2012-02-23 at 12:14 -0800, Roland Dreier wrote:
> From: Roland Dreier <roland@purestorage.com>
>
> We don't need to change the sign of our prm->residual field; the target
> core sets a flag to distinguish overflow and underflow, but
> se_cmd->residual_count is always positive. The existing code seems to
> be a carryover from the port from scst, which uses the sign of the
> residual field to distinguish overflow and underflow.
>
> Signed-off-by: Roland Dreier <roland@purestorage.com>
> ---
> drivers/scsi/qla2xxx/qla_target.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 9282014..b12fb84 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -1808,7 +1808,6 @@ static int qla_tgt_pre_xmit_response(struct qla_tgt_cmd *cmd, struct qla_tgt_prm
> se_cmd->t_task_cdb ? se_cmd->t_task_cdb[0] : 0,
> cmd->bufflen, prm->rq_result);
> prm->rq_result |= SS_RESIDUAL_OVER;
> - prm->residual = -prm->residual;
> }
>
> if (xmit_type & QLA_TGT_XMIT_STATUS) {
Applied. Thanks Roland!
--nab
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-25 1:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-23 20:14 [PATCH] qla2xxx: Fix sign of FCP_RESID field for status with RESID_OVER Roland Dreier
2012-02-25 1:11 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).