linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: target-devel <target-devel@vger.kernel.org>,
	linux-scsi <linux-scsi@vger.kernel.org>
Cc: Andy Grover <agrover@redhat.com>,
	Kiran Patil <kiran.patil@intel.com>,
	Arun Easi <arun.easi@qlogic.com>,
	Nicholas Bellinger <nab@linux-iscsi.org>
Subject: [PATCH 4/7] tcm_fc: Handle target_submit_tmr allocation failure
Date: Sat, 25 Feb 2012 21:05:56 +0000	[thread overview]
Message-ID: <1330203959-6170-5-git-send-email-nab@linux-iscsi.org> (raw)
In-Reply-To: <1330203959-6170-1-git-send-email-nab@linux-iscsi.org>

From: Nicholas Bellinger <nab@linux-iscsi.org>

This patch makes ft_send_tm() handle target_submit_tmr() allocation failures
via an ft_send_resp_code_and_free() w/ FCP_TMF_FAILED status.

Cc: Andy Grover <agrover@redhat.com>
Cc: Kiran Patil <kiran.patil@intel.com>
Cc: Arun Easi <arun.easi@qlogic.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
---
 drivers/target/tcm_fc/tfc_cmd.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/target/tcm_fc/tfc_cmd.c b/drivers/target/tcm_fc/tfc_cmd.c
index 1baee28..00dcc5f 100644
--- a/drivers/target/tcm_fc/tfc_cmd.c
+++ b/drivers/target/tcm_fc/tfc_cmd.c
@@ -354,6 +354,7 @@ static void ft_send_resp_code_and_free(struct ft_cmd *cmd,
 static void ft_send_tm(struct ft_cmd *cmd)
 {
 	struct fcp_cmnd *fcp;
+	int rc;
 	u8 tm_func;
 
 	fcp = fc_frame_payload_get(cmd->req_frame, sizeof(*fcp));
@@ -383,9 +384,11 @@ static void ft_send_tm(struct ft_cmd *cmd)
 		return;
 	}
 
-	target_submit_tmr(&cmd->se_cmd, cmd->sess->se_sess,
+	rc = target_submit_tmr(&cmd->se_cmd, cmd->sess->se_sess,
 		&cmd->ft_sense_buffer[0], scsilun_to_int(&fcp->fc_lun),
 			  cmd, tm_func, 0);
+	if (rc < 0)
+		ft_send_resp_code_and_free(cmd, FCP_TMF_FAILED);
 }
 
 /*
-- 
1.7.2.5


  parent reply	other threads:[~2012-02-25 21:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-25 21:05 [PATCH 0/7] target: Drop se_tmr_req inline + target_submit_tmr() fixes + conversion Nicholas A. Bellinger
2012-02-25 21:05 ` [PATCH 1/7] target: Drop inlining of se_tmr_req from se_cmd Nicholas A. Bellinger
2012-02-25 21:05 ` [PATCH 2/7] target: Fix target_submit_tmr LUN lookup failures Nicholas A. Bellinger
2012-02-25 21:05 ` [PATCH 3/7] target: Fix target_submit_tmr se_tmr_req allocation failures Nicholas A. Bellinger
2012-02-25 21:05 ` Nicholas A. Bellinger [this message]
2012-02-25 21:05 ` [PATCH 5/7] target: Push target_submit_tmr LUN lookup failure to system_wq context Nicholas A. Bellinger
2012-02-25 21:05 ` [PATCH 6/7] target: Allow target_submit_tmr to be called from interrupt context Nicholas A. Bellinger
2012-02-25 21:05 ` [PATCH 7/7] qla_target: Drop qla_tgt_mgmt_cmd->se_tmr_req usage Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330203959-6170-5-git-send-email-nab@linux-iscsi.org \
    --to=nab@linux-iscsi.org \
    --cc=agrover@redhat.com \
    --cc=arun.easi@qlogic.com \
    --cc=kiran.patil@intel.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).