* [PATCH] [SCSI] be2iscsi: Remove unused OFFSET_IN_PAGE() macro
@ 2012-03-01 6:41 Roland Dreier
2012-03-27 16:38 ` Roland Dreier
0 siblings, 1 reply; 4+ messages in thread
From: Roland Dreier @ 2012-03-01 6:41 UTC (permalink / raw)
To: Jayamohan Kallickal, James E.J. Bottomley; +Cc: linux-scsi
From: Roland Dreier <roland@purestorage.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
---
drivers/scsi/be2iscsi/be.h | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be.h b/drivers/scsi/be2iscsi/be.h
index 1d7b976..a50b6a9 100644
--- a/drivers/scsi/be2iscsi/be.h
+++ b/drivers/scsi/be2iscsi/be.h
@@ -132,10 +132,6 @@ struct be_ctrl_info {
((u32)((((size_t)(_address) & (PAGE_SIZE_4K - 1)) + \
(size) + (PAGE_SIZE_4K - 1)) >> PAGE_SHIFT_4K))
-/* Byte offset into the page corresponding to given address */
-#define OFFSET_IN_PAGE(addr) \
- ((size_t)(addr) & (PAGE_SIZE_4K-1))
-
/* Returns bit offset within a DWORD of a bitfield */
#define AMAP_BIT_OFFSET(_struct, field) \
(((size_t)&(((_struct *)0)->field))%32)
--
1.7.9
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] [SCSI] be2iscsi: Remove unused OFFSET_IN_PAGE() macro
2012-03-01 6:41 [PATCH] [SCSI] be2iscsi: Remove unused OFFSET_IN_PAGE() macro Roland Dreier
@ 2012-03-27 16:38 ` Roland Dreier
2012-03-27 17:28 ` Mike Christie
0 siblings, 1 reply; 4+ messages in thread
From: Roland Dreier @ 2012-03-27 16:38 UTC (permalink / raw)
To: Jayamohan Kallickal, James E.J. Bottomley; +Cc: linux-scsi
On Wed, Feb 29, 2012 at 10:41 PM, Roland Dreier <roland@kernel.org> wrote:
> From: Roland Dreier <roland@purestorage.com>
>
> Signed-off-by: Roland Dreier <roland@purestorage.com>
> ---
> drivers/scsi/be2iscsi/be.h | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/be2iscsi/be.h b/drivers/scsi/be2iscsi/be.h
> index 1d7b976..a50b6a9 100644
> --- a/drivers/scsi/be2iscsi/be.h
> +++ b/drivers/scsi/be2iscsi/be.h
> @@ -132,10 +132,6 @@ struct be_ctrl_info {
> ((u32)((((size_t)(_address) & (PAGE_SIZE_4K - 1)) + \
> (size) + (PAGE_SIZE_4K - 1)) >> PAGE_SHIFT_4K))
>
> -/* Byte offset into the page corresponding to given address */
> -#define OFFSET_IN_PAGE(addr) \
> - ((size_t)(addr) & (PAGE_SIZE_4K-1))
> -
> /* Returns bit offset within a DWORD of a bitfield */
> #define AMAP_BIT_OFFSET(_struct, field) \
> (((size_t)&(((_struct *)0)->field))%32)
ping? the corresponding be2net patch is upstream as 97767a87f3be.
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] [SCSI] be2iscsi: Remove unused OFFSET_IN_PAGE() macro
2012-03-27 16:38 ` Roland Dreier
@ 2012-03-27 17:28 ` Mike Christie
2012-03-28 21:30 ` Jayamohan.Kallickal
0 siblings, 1 reply; 4+ messages in thread
From: Mike Christie @ 2012-03-27 17:28 UTC (permalink / raw)
To: Roland Dreier; +Cc: Jayamohan Kallickal, James E.J. Bottomley, linux-scsi
On 03/27/2012 11:38 AM, Roland Dreier wrote:
> On Wed, Feb 29, 2012 at 10:41 PM, Roland Dreier <roland@kernel.org> wrote:
>> From: Roland Dreier <roland@purestorage.com>
>>
>> Signed-off-by: Roland Dreier <roland@purestorage.com>
>> ---
>> drivers/scsi/be2iscsi/be.h | 4 ----
>> 1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/scsi/be2iscsi/be.h b/drivers/scsi/be2iscsi/be.h
>> index 1d7b976..a50b6a9 100644
>> --- a/drivers/scsi/be2iscsi/be.h
>> +++ b/drivers/scsi/be2iscsi/be.h
>> @@ -132,10 +132,6 @@ struct be_ctrl_info {
>> ((u32)((((size_t)(_address) & (PAGE_SIZE_4K - 1)) + \
>> (size) + (PAGE_SIZE_4K - 1)) >> PAGE_SHIFT_4K))
>>
>> -/* Byte offset into the page corresponding to given address */
>> -#define OFFSET_IN_PAGE(addr) \
>> - ((size_t)(addr) & (PAGE_SIZE_4K-1))
>> -
>> /* Returns bit offset within a DWORD of a bitfield */
>> #define AMAP_BIT_OFFSET(_struct, field) \
>> (((size_t)&(((_struct *)0)->field))%32)
>
> ping? the corresponding be2net patch is upstream as 97767a87f3be.
>
Jay probably missed it, because he has been sick. Looks good to me.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] [SCSI] be2iscsi: Remove unused OFFSET_IN_PAGE() macro
2012-03-27 17:28 ` Mike Christie
@ 2012-03-28 21:30 ` Jayamohan.Kallickal
0 siblings, 0 replies; 4+ messages in thread
From: Jayamohan.Kallickal @ 2012-03-28 21:30 UTC (permalink / raw)
To: michaelc, roland; +Cc: JBottomley, linux-scsi
-----Original Message-----
From: Mike Christie [mailto:michaelc@cs.wisc.edu]
Sent: Tuesday, March 27, 2012 10:29 AM
To: Roland Dreier
Cc: Kallickal, Jayamohan; James E.J. Bottomley; linux-scsi@vger.kernel.org
Subject: Re: [PATCH] [SCSI] be2iscsi: Remove unused OFFSET_IN_PAGE() macro
On 03/27/2012 11:38 AM, Roland Dreier wrote:
> On Wed, Feb 29, 2012 at 10:41 PM, Roland Dreier <roland@kernel.org> wrote:
>> From: Roland Dreier <roland@purestorage.com>
>>
>> Signed-off-by: Roland Dreier <roland@purestorage.com>
>> ---
>> drivers/scsi/be2iscsi/be.h | 4 ----
>> 1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/scsi/be2iscsi/be.h b/drivers/scsi/be2iscsi/be.h
>> index 1d7b976..a50b6a9 100644
>> --- a/drivers/scsi/be2iscsi/be.h
>> +++ b/drivers/scsi/be2iscsi/be.h
>> @@ -132,10 +132,6 @@ struct be_ctrl_info {
>> ((u32)((((size_t)(_address) & (PAGE_SIZE_4K - 1)) + \
>> (size) + (PAGE_SIZE_4K - 1)) >>
>> PAGE_SHIFT_4K))
>>
>> -/* Byte offset into the page corresponding to given address */
>> -#define OFFSET_IN_PAGE(addr) \
>> - ((size_t)(addr) & (PAGE_SIZE_4K-1))
>> -
>> /* Returns bit offset within a DWORD of a bitfield */
>> #define AMAP_BIT_OFFSET(_struct, field) \
>> (((size_t)&(((_struct *)0)->field))%32)
>
> ping? the corresponding be2net patch is upstream as 97767a87f3be.
>
Jay probably missed it, because he has been sick. Looks good to me.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Thanks Mike for taking care of this
Acked-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-28 21:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-01 6:41 [PATCH] [SCSI] be2iscsi: Remove unused OFFSET_IN_PAGE() macro Roland Dreier
2012-03-27 16:38 ` Roland Dreier
2012-03-27 17:28 ` Mike Christie
2012-03-28 21:30 ` Jayamohan.Kallickal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox