[PATCH] bug fix for 42142

[PATCH] bug fix for 42142

[Sathisha Nanjappa]

Minor change to weed out the intended loginfo messages.

Sathisha Nanjappa (1):
  mpt2sas: Corrected the constant in comparison to a hexadecimal.

 drivers/scsi/mpt2sas/mpt2sas_base.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

-- 
1.7.7.6

[PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal.

[Sathisha Nanjappa]

    Bugzilla 42142 - mpt2sas: Number specified in wrong base
    https://bugzilla.kernel.org/show_bug.cgi?id=42142

Signed-off-by: Sathisha Nanjappa <sathisha.nanjappa@hp.com>
---
 drivers/scsi/mpt2sas/mpt2sas_base.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
index 0b2c955..f9a1244 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_base.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
@@ -657,7 +657,7 @@ _base_sas_log_info(struct MPT2SAS_ADAPTER *ioc , u32 log_info)
 		return;
 
 	/* eat the loginfos associated with task aborts */
-	if (ioc->ignore_loginfos && (log_info == 30050000 || log_info ==
+	if (ioc->ignore_loginfos && (log_info == 0x30050000 || log_info ==
 	    0x31140000 || log_info == 0x31130000))
 		return;
 
-- 
1.7.7.6

RE: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal.

[Nandigama, Nagalakshmi]

This patch seem to be fine. Please consider this patch as Acked-by: "Nandigama, Nagalakshmi" <Nagalakshmi.Nandigama@lsi.com>

Regards,
Nagalakshmi


-----Original Message-----
From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of Sathisha Nanjappa
Sent: Wednesday, March 14, 2012 12:29 AM
To: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org
Cc: Sathisha Nanjappa
Subject: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal.

    Bugzilla 42142 - mpt2sas: Number specified in wrong base
    https://bugzilla.kernel.org/show_bug.cgi?id=42142

Signed-off-by: Sathisha Nanjappa <sathisha.nanjappa@hp.com>
---
 drivers/scsi/mpt2sas/mpt2sas_base.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
index 0b2c955..f9a1244 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_base.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
@@ -657,7 +657,7 @@ _base_sas_log_info(struct MPT2SAS_ADAPTER *ioc , u32 log_info)
 		return;
 
 	/* eat the loginfos associated with task aborts */
-	if (ioc->ignore_loginfos && (log_info == 30050000 || log_info ==
+	if (ioc->ignore_loginfos && (log_info == 0x30050000 || log_info ==
 	    0x31140000 || log_info == 0x31130000))
 		return;
 
-- 
1.7.7.6

Re: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal.

[James Bottomley]

On Tue, 2012-03-13 at 11:59 -0700, Sathisha Nanjappa wrote:
> Bugzilla 42142 - mpt2sas: Number specified in wrong base
>     https://bugzilla.kernel.org/show_bug.cgi?id=42142

Do you have a better description ... like what is the user visible
effect of correcting the constant?

James

RE: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal.

[Nanjappa, Sathisha (MCXS, Cupertino)]

> 
> On Tue, 2012-03-13 at 11:59 -0700, Sathisha Nanjappa wrote:
> > Bugzilla 42142 - mpt2sas: Number specified in wrong base
> >     https://bugzilla.kernel.org/show_bug.cgi?id=42142
> 
> From: James Bottomley
> Sent: Wednesday, March 14, 2012 1:34 AM
> Do you have a better description ... like what is the user
> visible effect of correcting the constant?
>

Does this look better:

"This fix ensures that the IOP_LOGINFO_CODE_TASK_TERMINATED
messages do not clutter the sas_log_info messages."

Thanks,
-Satish.

RE: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal.

[James Bottomley]

On Wed, 2012-03-14 at 23:36 +0000, Nanjappa, Sathisha (MCXS, Cupertino)
wrote:
> > 
> > On Tue, 2012-03-13 at 11:59 -0700, Sathisha Nanjappa wrote:
> > > Bugzilla 42142 - mpt2sas: Number specified in wrong base
> > >     https://bugzilla.kernel.org/show_bug.cgi?id=42142
> > 
> > From: James Bottomley
> > Sent: Wednesday, March 14, 2012 1:34 AM
> > Do you have a better description ... like what is the user
> > visible effect of correcting the constant?
> >
> 
> Does this look better:
> 
> "This fix ensures that the IOP_LOGINFO_CODE_TASK_TERMINATED
> messages do not clutter the sas_log_info messages."

Much better, thanks.  The whole point of a commit message is to explain
what you're doing and why you're doing it.  Just translating C to
english isn't useful because everyone who looks a kernel patches can
read C.

James

RE: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal.

[Nanjappa, Sathisha (MCXS, Cupertino)]

> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> owner@vger.kernel.org] On Behalf Of James Bottomley
> Sent: Thursday, March 15, 2012 1:57 AM
> 
> On Wed, 2012-03-14 at 23:36 +0000, Nanjappa, Sathisha (MCXS, Cupertino)
> wrote:
> > >
> > > On Tue, 2012-03-13 at 11:59 -0700, Sathisha Nanjappa wrote:
> > > > Bugzilla 42142 - mpt2sas: Number specified in wrong base
> > > >     https://bugzilla.kernel.org/show_bug.cgi?id=42142
> > >
> > > From: James Bottomley
> > > Sent: Wednesday, March 14, 2012 1:34 AM
> > > Do you have a better description ... like what is the user
> > > visible effect of correcting the constant?
> > >
> >
> > Does this look better:
> >
> > "This fix ensures that the IOP_LOGINFO_CODE_TASK_TERMINATED
> > messages do not clutter the sas_log_info messages."
> 
> Much better, thanks.  The whole point of a commit message is to explain
> what you're doing and why you're doing it.  Just translating C to
> english isn't useful because everyone who looks a kernel patches can
> read C.
> 

Thanks for clarifying. I'll keep that in mind during my future submittal requests.

FYI, I've received ack's from:

Acked-by: "Nandigama, Nagalakshmi" <Nagalakshmi.Nandigama@lsi.com>
Acked-by: "Chris Dunlop" <chris@onthe.net.au> 

-Satish.