From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: "Jörn Engel" <joern@logfs.org>
Cc: Andrew Vasquez <andrew.vasquez@qlogic.com>,
target-devel@vger.kernel.org, linux-driver@qlogic.com,
linux-scsi@vger.kernel.org, Arun Easi <arun.easi@qlogic.com>,
Giridhar Malavali <giridhar.malavali@qlogic.com>,
James Bottomley <jbottomley@parallels.com>
Subject: Re: [PATCH 3/6] qla2xxx: remove obvious warnings
Date: Thu, 15 Mar 2012 14:37:23 -0700 [thread overview]
Message-ID: <1331847443.10203.63.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20120315190639.GD7685@logfs.org>
On Thu, 2012-03-15 at 15:06 -0400, Jörn Engel wrote:
> Get rid of a bunch of write-only variables. In a number of cases I
> suspect actual bugs to be present, so I left all of those for a second
> look.
>
> Signed-off-by: Joern Engel <joern@logfs.org>
> ---
> drivers/scsi/qla2xxx/qla_attr.c | 2 --
> drivers/scsi/qla2xxx/qla_bsg.c | 2 --
> drivers/scsi/qla2xxx/qla_dbg.c | 9 ---------
> drivers/scsi/qla2xxx/qla_init.c | 2 --
> drivers/scsi/qla2xxx/qla_iocb.c | 17 ++---------------
> drivers/scsi/qla2xxx/qla_isr.c | 2 --
> drivers/scsi/qla2xxx/qla_mbx.c | 4 ----
> drivers/scsi/qla2xxx/qla_mid.c | 3 +--
> drivers/scsi/qla2xxx/qla_nx.c | 9 +++------
> drivers/scsi/qla2xxx/qla_os.c | 8 +-------
> drivers/scsi/qla2xxx/qla_target.c | 8 ++------
> 11 files changed, 9 insertions(+), 57 deletions(-)
>
This patch does not apply against lio-core HEAD, and since some of this
code is not directly target related, those pieces should be going
through the scsi tree.
--nab
next prev parent reply other threads:[~2012-03-15 21:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120315190512.GB7685@logfs.org>
2012-03-15 19:06 ` [PATCH 3/6] qla2xxx: remove obvious warnings Jörn Engel
2012-03-15 21:37 ` Nicholas A. Bellinger [this message]
2012-03-15 19:07 ` [PATCH 5/6] qla2xxx: Rewrite ISP_QUE_REG as inline function Jörn Engel
2012-03-15 21:38 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331847443.10203.63.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=andrew.vasquez@qlogic.com \
--cc=arun.easi@qlogic.com \
--cc=giridhar.malavali@qlogic.com \
--cc=jbottomley@parallels.com \
--cc=joern@logfs.org \
--cc=linux-driver@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox