From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Gerard Snitselaar <dev@snitselaar.org>
Cc: andrew.vasquez@qlogic.com, linux-driver@qlogic.com,
JBottomley@parallels.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
target-devel <target-devel@vger.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: fix section mismatch in linux-next
Date: Thu, 15 Mar 2012 16:31:16 -0700 [thread overview]
Message-ID: <1331854276.10203.143.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <1331847626-11141-1-git-send-email-dev@snitselaar.org>
On Thu, 2012-03-15 at 14:40 -0700, Gerard Snitselaar wrote:
> qla_tgt_exit() is annotated __exit , but called in
> qla2x00_module_init().
>
> Signed-off-by: Gerard Snitselaar <dev@snitselaar.org>
> ---
> drivers/scsi/qla2xxx/qla_target.c | 2 +-
> drivers/scsi/qla2xxx/qla_target.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
Hi Gerard,
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 6d6f1cf..699d16e 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -4730,7 +4730,7 @@ out:
> return ret;
> }
>
> -void __exit qla_tgt_exit(void)
> +void qla_tgt_exit(void)
> {
> destroy_workqueue(qla_tgt_wq);
> mempool_destroy(qla_tgt_mgmt_cmd_mempool);
> diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h
> index db6b399..b9d0aa1 100644
> --- a/drivers/scsi/qla2xxx/qla_target.h
> +++ b/drivers/scsi/qla2xxx/qla_target.h
> @@ -934,7 +934,7 @@ extern void qla_tgt_fc_port_deleted(struct scsi_qla_host *, fc_port_t *);
> extern void qla_tgt_set_mode(struct scsi_qla_host *ha);
> extern void qla_tgt_clear_mode(struct scsi_qla_host *ha);
> extern int __init qla_tgt_init(void);
> -extern void __exit qla_tgt_exit(void);
> +extern void qla_tgt_exit(void);
>
> static inline bool qla_tgt_mode_enabled(struct scsi_qla_host *ha)
> {
This looks fine. Applied to lio-core, and will get this fixed up in
target-pending/for-next-merge shortly.
Thanks for your patch!
--nab
prev parent reply other threads:[~2012-03-15 23:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 21:40 [PATCH] scsi: qla2xxx: fix section mismatch in linux-next Gerard Snitselaar
2012-03-15 23:31 ` Nicholas A. Bellinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331854276.10203.143.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=JBottomley@parallels.com \
--cc=andrew.vasquez@qlogic.com \
--cc=dev@snitselaar.org \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox