From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Love, Robert W" <robert.w.love@intel.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"giridhar.malavali@qlogic.com" <giridhar.malavali@qlogic.com>,
"james.smart@emulex.com" <james.smart@emulex.com>,
"bprakash@broadcom.com" <bprakash@broadcom.com>
Subject: Re: [PATCH v2 3/4] libfcoe: Add fcoe_sysfs
Date: Sat, 17 Mar 2012 09:07:07 +0000 [thread overview]
Message-ID: <1331975227.2855.8.camel@dabdike> (raw)
In-Reply-To: <4F63E4E9.2010504@intel.com>
On Sat, 2012-03-17 at 01:12 +0000, Love, Robert W wrote:
> >> + ctlr->id = atomic_inc_return(&ctlr_num) - 1;
> > Does this work properly over the long run? Shouldn't you use the
> idr
> > interface instead, to keep holes from showing up?
>
> I'm not familiar wit the idr interface. I'll ask around and fix this.
>
The rule of thumb we've been using for idr in SCSI is that we don't
bother with it unless the name space is constrained. So for sd<x> we
use it because we have a limited device space to fill (constrained by
minor numbers) for target<n> we just use an incrementing counter because
<n> is unconstrained.
James
next prev parent reply other threads:[~2012-03-17 9:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 19:36 [PATCH v2 0/4] FCoE Sysfs Robert Love
2012-03-16 19:36 ` [PATCH v2 1/4] fcoe: Allocate fcoe_ctlr with fcoe_interface, not as a member Robert Love
2012-03-16 19:36 ` [PATCH v2 2/4] bnx2fc: Allocate fcoe_ctlr with bnx2fc_interface, " Robert Love
2012-03-16 19:36 ` [PATCH v2 3/4] libfcoe: Add fcoe_sysfs Robert Love
2012-03-17 0:25 ` Greg KH
2012-03-17 1:12 ` Love, Robert W
2012-03-17 9:07 ` James Bottomley [this message]
2012-03-20 21:01 ` Greg KH
2012-03-20 1:23 ` Love, Robert W
2012-03-20 21:05 ` Greg KH
2012-03-16 19:37 ` [PATCH v2 4/4] fcoe, bnx2fc, libfcoe: SW FCoE and bnx2fc use FCoE Syfs Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331975227.2855.8.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=bprakash@broadcom.com \
--cc=giridhar.malavali@qlogic.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
--cc=robert.w.love@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox