* [PATCH 03/13] ada152x: Remove broken usage of spin_is_locked
[not found] <1332895637-32572-1-git-send-email-andi@firstfloor.org>
@ 2012-03-28 0:47 ` Andi Kleen
0 siblings, 0 replies; only message in thread
From: Andi Kleen @ 2012-03-28 0:47 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, Andi Kleen, James.Bottomley, linux-scsi
From: Andi Kleen <ak@linux.intel.com>
Remove racy usage of spin_is_locked. The author seems to have been
unclear on the concept of locking.
This is debug code normally not enabled, but I caught it on a tree sweep.
Cc: James.Bottomley@HansenPartnership.com
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
drivers/scsi/aha152x.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c
index f17c92c..c56b617 100644
--- a/drivers/scsi/aha152x.c
+++ b/drivers/scsi/aha152x.c
@@ -288,9 +288,6 @@ static LIST_HEAD(aha152x_host_list);
#define DO_LOCK(flags) \
do { \
- if(spin_is_locked(&QLOCK)) { \
- DPRINTK(debug_intr, DEBUG_LEAD "(%s:%d) already locked at %s:%d\n", CMDINFO(CURRENT_SC), __func__, __LINE__, QLOCKER, QLOCKERL); \
- } \
DPRINTK(debug_locking, DEBUG_LEAD "(%s:%d) locking\n", CMDINFO(CURRENT_SC), __func__, __LINE__); \
spin_lock_irqsave(&QLOCK,flags); \
DPRINTK(debug_locking, DEBUG_LEAD "(%s:%d) locked\n", CMDINFO(CURRENT_SC), __func__, __LINE__); \
--
1.7.7.6
^ permalink raw reply related [flat|nested] only message in thread