From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Nandigama, Nagalakshmi" <Nagalakshmi.Nandigama@lsi.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: RE: [RESEND PATCH] mptsas: Fixed code to check whether the LU type is SSC or not for SILI bit in READ_6 and READ_16 CDB
Date: Thu, 29 Mar 2012 08:51:50 +0100 [thread overview]
Message-ID: <1333007510.2823.7.camel@dabdike> (raw)
In-Reply-To: <A6888A6805518E4EA4AF7072A28264A6067E6736F1@inbmail02.lsi.com>
On Wed, 2012-03-07 at 15:04 +0530, Nandigama, Nagalakshmi wrote:
> -----Original Message-----
> From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com]
> Sent: Wednesday, March 07, 2012 6:13 AM
> To: Nandigama, Nagalakshmi
> Cc: stable@vger.kernel.org; linux-scsi
> Subject: Re: [RESEND PATCH] mptsas: Fixed code to check whether the LU type is SSC or not for SILI bit in READ_6 and READ_16 CDB
>
> On Tue, 2012-03-06 at 12:16 +0530, nagalakshmi.nandigama@lsi.com wrote:
> >> This SILI bit (suppress incorrect length indicator) is defined only for SSC
> >> READ(6) and READ(16) commands. For other device types bit is part of LBA
>
> >This isn't right ... it is for READ(6) but it's FUA_NV for
> >READ(10,12,16) on block devices.
>
>
> For READ6, READ16 SSC commands, the BIT 1of BYTE 2 is SILI. (As per SSC4 specs)
> For block commands, the BIT 1of BYTE 2 is part of LBA for READ6 and FUA_NV bit for
> READ(10,12,16).
>
> So it is required to check whether the logical unit is SSC device or not when checking SILI bit.
> So in the patch which I sent, I added this piece of code.
That's what the standards say, yes, I know that. If there's a visible
bug, this is the description of the cause. What I'm asking is what is
the actual user visible effect? The change log needs to include that to
give people who read it an idea of why they might need to apply the fix.
James
next prev parent reply other threads:[~2012-03-29 7:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 6:46 [RESEND PATCH] mptsas: Fixed code to check whether the LU type is SSC or not for SILI bit in READ_6 and READ_16 CDB nagalakshmi.nandigama
2012-03-07 0:43 ` James Bottomley
2012-03-07 9:34 ` Nandigama, Nagalakshmi
2012-03-29 7:51 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-05 4:54 nagalakshmi.nandigama
2012-03-05 16:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333007510.2823.7.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=Nagalakshmi.Nandigama@lsi.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).