Re: An oops will occur while SCSI core is being used in 3.4-rc1

Martin K. Petersen
2012-04-12T00:48:59Z

>>>>> "Bart" == Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org> writes:

Bart> That comment didn't make sense - request.rq_disk is not modified
Bart> after it has been initialized.

Correct.

Bart> Yet it would make me more happy if scsi_send_eh_cmnd() could be
Bart> modified such that it doesn't have to access struct scsi_driver.

Well, the whole point of the original patch was that we wanted to enable
upper level drivers to interact with the current (SPC-centric) error
handling.

I understand your concern given the recent flurry of device lifetime
issues. But I think the issues my patch tries to tackle are important
enough to warrant the change. And we definitely don't want to start
mucking with block device-specific commands in the generic error
handling path.

--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html