Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Chandra Seetharaman <sekharan@us.ibm.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: "Moger, Babu" <Babu.Moger@netapp.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	device-mapper development <dm-devel@redhat.com>,
	"Krishnasamy, Somasundaram" <Somasundaram.Krishnasamy@netapp.com>
Subject: Re: [PATCH] scsi_dh_rdac: Add dynamic match functionality to rdac handler
Date: Fri, 20 Apr 2012 13:05:30 -0500	[thread overview]
Message-ID: <1334945131.3420.33.camel@chandra-lucid.austin.ibm.com> (raw)
In-Reply-To: <4F919351.3050000@cs.wisc.edu>

On Fri, 2012-04-20 at 11:48 -0500, Mike Christie wrote:
> On 04/20/2012 11:27 AM, Chandra Seetharaman wrote:
> > Babu,
> > 
> > So, in effect, any SCSI devices with INQ C8 page with "edid" would be
> > treated as a rdac device, right ?
> > 
> > Is that enough to identify _any_ SCSI device as a rdac device (even in
> > future) ?
> > 
> > Also, instead of repeating the code, can you use submit_inquiry() ?
> > 
> 
> Yeah you are right, I think we should modify submit_inquiry to take in
> the sense and data buffers instead of taking in the rdac_dh_data struct.
> At the time the match function is run rdac_dh_data might not be allocated.

oh yeah,

I did not not realize that...
> 



  reply	other threads:[~2012-04-20 18:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-10 17:06 [PATCH] scsi_dh_rdac: Add dynamic match functionality to rdac handler Moger, Babu
2012-04-18  5:32 ` Mike Christie
2012-04-20 16:27 ` Chandra Seetharaman
2012-04-20 16:48   ` Mike Christie
2012-04-20 18:05     ` Chandra Seetharaman [this message]
2012-04-20 20:45       ` Moger, Babu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334945131.3420.33.camel@chandra-lucid.austin.ibm.com \
    --to=sekharan@us.ibm.com \
    --cc=Babu.Moger@netapp.com \
    --cc=Somasundaram.Krishnasamy@netapp.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox