From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] target: lock => unlock typo
Date: Tue, 08 May 2012 19:28:44 -0700 [thread overview]
Message-ID: <1336530524.8722.61.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20120508102858.GA21528@elgon.mountain>
On Tue, 2012-05-08 at 13:28 +0300, Dan Carpenter wrote:
> target_stop_cmd() returns with the lock held and IRQs disabled. The
> intent was to unlock here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index 0d838ab..8bd9ffe 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -3769,7 +3769,7 @@ static int transport_lun_wait_for_tasks(struct se_cmd *cmd, struct se_lun *lun)
> (cmd->transport_state & CMD_T_SENT)) {
> if (!target_stop_cmd(cmd, &flags))
> ret++;
> - spin_lock_irqsave(&cmd->t_state_lock, flags);
> + spin_unlock_irqrestore(&cmd->t_state_lock, flags);
> } else {
> spin_unlock_irqrestore(&cmd->t_state_lock,
> flags);
> --
Applied to lio-core, and folding into hch's original commit that
introduced the bug in for-next.
Thanks Dan!
--nab
prev parent reply other threads:[~2012-05-09 2:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 10:28 [patch] target: lock => unlock typo Dan Carpenter
2012-05-08 14:35 ` Christoph Hellwig
2012-05-09 2:28 ` Nicholas A. Bellinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336530524.8722.61.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=dan.carpenter@oracle.com \
--cc=hch@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox