From: Emil Goode <emilgoode@gmail.com>
To: JBottomley@parallels.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Emil Goode <emilgoode@gmail.com>
Subject: [PATCH] [SCSI] scsi_pm: Argument to scsi_device_resume should be scsi_device pointer
Date: Mon, 21 May 2012 12:32:00 +0200 [thread overview]
Message-ID: <1337596320-32330-1-git-send-email-emilgoode@gmail.com> (raw)
The call to scsi_device_resume expects a struct scsi_device pointer.
We should use the to_scsi_device macro here.
Sparse is warning about this:
drivers/scsi/scsi_pm.c:30:5: warning:
passing argument 1 of ‘scsi_device_resume’
from incompatible pointer type [enabled by default]
include/scsi/scsi_device.h:368:13: note:
expected ‘struct scsi_device *’
but argument is of type ‘struct device *’
Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
drivers/scsi/scsi_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_pm.c b/drivers/scsi/scsi_pm.c
index 9bd2c41..d4201de 100644
--- a/drivers/scsi/scsi_pm.c
+++ b/drivers/scsi/scsi_pm.c
@@ -27,7 +27,7 @@ static int scsi_dev_type_suspend(struct device *dev, pm_message_t msg)
if (drv && drv->suspend) {
err = drv->suspend(dev, msg);
if (err)
- scsi_device_resume(dev);
+ scsi_device_resume(to_scsi_device(dev));
}
}
dev_dbg(dev, "scsi suspend: %d\n", err);
--
1.7.10
reply other threads:[~2012-05-21 10:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337596320-32330-1-git-send-email-emilgoode@gmail.com \
--to=emilgoode@gmail.com \
--cc=JBottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).