linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] [SCSI] scsi_pm: Argument to scsi_device_resume should be scsi_device pointer
@ 2012-05-21 10:32 Emil Goode
  0 siblings, 0 replies; only message in thread
From: Emil Goode @ 2012-05-21 10:32 UTC (permalink / raw)
  To: JBottomley; +Cc: linux-scsi, linux-kernel, Emil Goode

The call to scsi_device_resume expects a struct scsi_device pointer.
We should use the to_scsi_device macro here.

Sparse is warning about this:
drivers/scsi/scsi_pm.c:30:5: warning:
	passing argument 1 of ‘scsi_device_resume’
	from incompatible pointer type [enabled by default]
	include/scsi/scsi_device.h:368:13: note:
	expected ‘struct scsi_device *’
	but argument is of type ‘struct device *’

Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
 drivers/scsi/scsi_pm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_pm.c b/drivers/scsi/scsi_pm.c
index 9bd2c41..d4201de 100644
--- a/drivers/scsi/scsi_pm.c
+++ b/drivers/scsi/scsi_pm.c
@@ -27,7 +27,7 @@ static int scsi_dev_type_suspend(struct device *dev, pm_message_t msg)
 		if (drv && drv->suspend) {
 			err = drv->suspend(dev, msg);
 			if (err)
-				scsi_device_resume(dev);
+				scsi_device_resume(to_scsi_device(dev));
 		}
 	}
 	dev_dbg(dev, "scsi suspend: %d\n", err);
-- 
1.7.10

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-05-21 10:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-21 10:32 [PATCH] [SCSI] scsi_pm: Argument to scsi_device_resume should be scsi_device pointer Emil Goode

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).