[PATCH v4 3/3] usb: storage: update usb devices for write cache quirk in quirk list.

linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH v4 3/3] usb: storage: update usb devices for write cache quirk in quirk list.
@ 2012-06-13 15:28 Namjae Jeon
  0 siblings, 0 replies; 8+ messages in thread
From: Namjae Jeon @ 2012-06-13 15:28 UTC (permalink / raw)
  To: James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r,
	mdharm-usb-JGfshJpz5UybPZpvUQj5UqxOck334EZe,
	stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz,
	sshtylyov-Igf4POYTYCDQT0dZR+AlfA, bvanassche-HInyCGIudOg
  Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
	linux-scsi-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Namjae Jeon, Pankaj Kumar,
	Amit Sahrawat

From: Namjae Jeon <namjae.jeon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

Update information of Seagate Portable HDD and WD My Passport HDD in
quirk list.

Signed-off-by: Namjae Jeon <namjae.jeon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Pankaj Kumar <pankaj.km-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Amit Sahrawat <a.sahrawat-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Acked-by: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
---
 drivers/usb/storage/unusual_devs.h |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 1719886..62a31be 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -1267,6 +1267,12 @@ UNUSUAL_DEV( 0x0af0, 0xd357, 0x0000, 0x0000,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		0 ),
 
+/* Reported by Namjae Jeon <namjae.jeon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> */
+UNUSUAL_DEV(0x0bc2, 0x2300, 0x0000, 0x9999,
+		"Seagate",
+		"Portable HDD",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
+
 /* Reported by Ben Efros <ben-sBIqA0PYact54TAoqtyWWQ@public.gmane.org> */
 UNUSUAL_DEV( 0x0bc2, 0x3010, 0x0000, 0x0000,
 		"Seagate",
@@ -1468,6 +1474,12 @@ UNUSUAL_DEV(  0x1058, 0x0704, 0x0000, 0x9999,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_SANE_SENSE),
 
+/* Reported by Namjae Jeon <namjae.jeon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> */
+UNUSUAL_DEV(0x1058, 0x070a, 0x0000, 0x9999,
+		"Western Digital",
+		"My Passport HDD",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
+
 /* Reported by Fabio Venturi <f.venturi-NTqSPVcvfic@public.gmane.org>
  * The device reports a vendor-specific bDeviceClass.
  */
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v4 3/3] usb: storage: update usb devices for write cache quirk in quirk list.
@ 2012-06-12 14:26 Namjae Jeon
  2012-06-12 14:31 ` Alan Stern
  2012-06-13  1:11 ` Greg KH
  0 siblings, 2 replies; 8+ messages in thread
From: Namjae Jeon @ 2012-06-12 14:26 UTC (permalink / raw)
  To: James.Bottomley, gregkh, mdharm-usb, stern, sshtylyov, bvanassche
  Cc: linux-usb, linux-scsi, linux-kernel, Namjae Jeon, Namjae Jeon,
	Pankaj Kumar, Amit Sahrawat

Update information of Seagate Portable HDD and WD My Passport HDD in
quirk list.

Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Pankaj Kumar <pankaj.km@samsung.com>
Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
---
 drivers/usb/storage/unusual_devs.h |   12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 1719886..62a31be 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -1267,6 +1267,12 @@ UNUSUAL_DEV( 0x0af0, 0xd357, 0x0000, 0x0000,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		0 ),
 
+/* Reported by Namjae Jeon <namjae.jeon@samsung.com> */
+UNUSUAL_DEV(0x0bc2, 0x2300, 0x0000, 0x9999,
+		"Seagate",
+		"Portable HDD",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
+
 /* Reported by Ben Efros <ben@pc-doctor.com> */
 UNUSUAL_DEV( 0x0bc2, 0x3010, 0x0000, 0x0000,
 		"Seagate",
@@ -1468,6 +1474,12 @@ UNUSUAL_DEV(  0x1058, 0x0704, 0x0000, 0x9999,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_SANE_SENSE),
 
+/* Reported by Namjae Jeon <namjae.jeon@samsung.com> */
+UNUSUAL_DEV(0x1058, 0x070a, 0x0000, 0x9999,
+		"Western Digital",
+		"My Passport HDD",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
+
 /* Reported by Fabio Venturi <f.venturi@tdnet.it>
  * The device reports a vendor-specific bDeviceClass.
  */
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v4 3/3] usb: storage: update usb devices for write cache quirk in quirk list.
  2012-06-12 14:26 Namjae Jeon
@ 2012-06-12 14:31 ` Alan Stern
  2012-06-13  1:11 ` Greg KH
  1 sibling, 0 replies; 8+ messages in thread
From: Alan Stern @ 2012-06-12 14:31 UTC (permalink / raw)
  To: Namjae Jeon
  Cc: James.Bottomley, gregkh, mdharm-usb, sshtylyov, bvanassche,
	linux-usb, linux-scsi, linux-kernel, Namjae Jeon, Pankaj Kumar,
	Amit Sahrawat

On Tue, 12 Jun 2012, Namjae Jeon wrote:

> Update information of Seagate Portable HDD and WD My Passport HDD in
> quirk list.
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Pankaj Kumar <pankaj.km@samsung.com>
> Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
> ---
>  drivers/usb/storage/unusual_devs.h |   12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index 1719886..62a31be 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -1267,6 +1267,12 @@ UNUSUAL_DEV( 0x0af0, 0xd357, 0x0000, 0x0000,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		0 ),
>  
> +/* Reported by Namjae Jeon <namjae.jeon@samsung.com> */
> +UNUSUAL_DEV(0x0bc2, 0x2300, 0x0000, 0x9999,
> +		"Seagate",
> +		"Portable HDD",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
> +
>  /* Reported by Ben Efros <ben@pc-doctor.com> */
>  UNUSUAL_DEV( 0x0bc2, 0x3010, 0x0000, 0x0000,
>  		"Seagate",
> @@ -1468,6 +1474,12 @@ UNUSUAL_DEV(  0x1058, 0x0704, 0x0000, 0x9999,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		US_FL_SANE_SENSE),
>  
> +/* Reported by Namjae Jeon <namjae.jeon@samsung.com> */
> +UNUSUAL_DEV(0x1058, 0x070a, 0x0000, 0x9999,
> +		"Western Digital",
> +		"My Passport HDD",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
> +
>  /* Reported by Fabio Venturi <f.venturi@tdnet.it>
>   * The device reports a vendor-specific bDeviceClass.
>   */

Acked-by: Alan Stern <stern@rowland.harvard.edu>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v4 3/3] usb: storage: update usb devices for write cache quirk in quirk list.
  2012-06-12 14:26 Namjae Jeon
  2012-06-12 14:31 ` Alan Stern
@ 2012-06-13  1:11 ` Greg KH
       [not found]   ` <20120613011114.GF6765-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
  1 sibling, 1 reply; 8+ messages in thread
From: Greg KH @ 2012-06-13  1:11 UTC (permalink / raw)
  To: Namjae Jeon
  Cc: James.Bottomley, mdharm-usb, stern, sshtylyov, bvanassche,
	linux-usb, linux-scsi, linux-kernel, Namjae Jeon, Pankaj Kumar,
	Amit Sahrawat

On Tue, Jun 12, 2012 at 10:26:30AM -0400, Namjae Jeon wrote:
> Update information of Seagate Portable HDD and WD My Passport HDD in
> quirk list.
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Pankaj Kumar <pankaj.km@samsung.com>
> Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
> ---
>  drivers/usb/storage/unusual_devs.h |   12 ++++++++++++
>  1 file changed, 12 insertions(+)

What happened to the 2 other patches in this series?

And why is your From: email address different from your Signed-off-by:
address?  If you are emailing from a different email account than your
"real" one, please put a "From: My name <email_address>" as the first
line in the body of the text for the patch, so git will get things
correct (see the file, Documentation/SubmittingPatches for details about
this.)

So, care to resend these so I can apply them?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

[parent not found: <20120613011114.GF6765-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>]

* Re: [PATCH v4 3/3] usb: storage: update usb devices for write cache quirk in quirk list.
       [not found]   ` <20120613011114.GF6765-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
@ 2012-06-13  1:27     ` Namjae Jeon
  0 siblings, 0 replies; 8+ messages in thread
From: Namjae Jeon @ 2012-06-13  1:27 UTC (permalink / raw)
  To: Greg KH
  Cc: James.Bottomley-JuX6DAaQMKPCXq6kfMZ53/egYHeGw8Jk,
	mdharm-usb-JGfshJpz5UybPZpvUQj5UqxOck334EZe,
	stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz,
	sshtylyov-Igf4POYTYCDQT0dZR+AlfA, bvanassche-HInyCGIudOg,
	linux-usb-u79uwXL29TY76Z2rM5mHXA,
	linux-scsi-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Namjae Jeon, Pankaj Kumar,
	Amit Sahrawat

2012/6/13, Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>:
> On Tue, Jun 12, 2012 at 10:26:30AM -0400, Namjae Jeon wrote:
>> Update information of Seagate Portable HDD and WD My Passport HDD in
>> quirk list.
>>
>> Signed-off-by: Namjae Jeon <namjae.jeon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>> Signed-off-by: Pankaj Kumar <pankaj.km-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>> Signed-off-by: Amit Sahrawat <a.sahrawat-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>> ---
>>  drivers/usb/storage/unusual_devs.h |   12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>
Dear Greg.
> What happened to the 2 other patches in this series?
The reason is that I tried to send patch again after making the
mistake(Patch number).
I will resend the patches after arranging.
>
> And why is your From: email address different from your Signed-off-by:
> address?  If you are emailing from a different email account than your
> "real" one, please put a "From: My name <email_address>" as the first
> line in the body of the text for the patch, so git will get things
> correct (see the file, Documentation/SubmittingPatches for details about
> this.)
>
> So, care to resend these so I can apply them?
Yes, sure, I will resend the patches after changing.
Thanks.
>
> thanks,
>
> greg k-h
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v4 3/3] usb: storage: update usb devices for write cache quirk in quirk list.
@ 2012-06-11 13:29 Namjae Jeon
  2012-06-11 14:19 ` Alan Stern
  0 siblings, 1 reply; 8+ messages in thread
From: Namjae Jeon @ 2012-06-11 13:29 UTC (permalink / raw)
  To: James.Bottomley, gregkh, mdharm-usb, stern, sshtylyov, bvanassche
  Cc: linux-usb, linux-scsi, linux-kernel, Namjae Jeon, Namjae Jeon,
	Pankaj Kumar, Amit Sahrawat

Update information of Seagate Portable HDD and WD My Passport HDD in
quirk list.

Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Pankaj Kumar <pankaj.km@samsung.com>
Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
---
 drivers/usb/storage/unusual_devs.h |   24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 1719886..64f0369 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -1267,6 +1267,18 @@ UNUSUAL_DEV( 0x0af0, 0xd357, 0x0000, 0x0000,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		0 ),
 
+/* Reported by Namjae Jeon <namjae.jeon@samsung.com>
+ * Even though write cache is enabled by default,
+ * SCSI driver assume that cache is not enabled
+ * which in turn might lead to the loss of data
+ * since data still will be in cache.
+ * So this entry is needed for assuming that cache is enabled.
+ */
+UNUSUAL_DEV(0x0bc2, 0x2300, 0x0000, 0x9999,
+		"Seagate",
+		"Portable HDD",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
+
 /* Reported by Ben Efros <ben@pc-doctor.com> */
 UNUSUAL_DEV( 0x0bc2, 0x3010, 0x0000, 0x0000,
 		"Seagate",
@@ -1468,6 +1480,18 @@ UNUSUAL_DEV(  0x1058, 0x0704, 0x0000, 0x9999,
 		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
 		US_FL_SANE_SENSE),
 
+/* Reported by Namjae Jeon <namjae.jeon@samsung.com>
+ * Even though write cache is enabled by default,
+ * SCSI driver assume that cache is not enabled
+ * which in turn might lead to the loss of data
+ * since data still will be in cache.
+ * So this entry is needed for assuming that cache is enabled.
+ */
+UNUSUAL_DEV(0x1058, 0x070a, 0x0000, 0x9999,
+		"Western Digital",
+		"My Passport HDD",
+		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
+
 /* Reported by Fabio Venturi <f.venturi@tdnet.it>
  * The device reports a vendor-specific bDeviceClass.
  */
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v4 3/3] usb: storage: update usb devices for write cache quirk in quirk list.
  2012-06-11 13:29 Namjae Jeon
@ 2012-06-11 14:19 ` Alan Stern
  2012-06-11 22:45   ` Namjae Jeon
  0 siblings, 1 reply; 8+ messages in thread
From: Alan Stern @ 2012-06-11 14:19 UTC (permalink / raw)
  To: Namjae Jeon
  Cc: James.Bottomley, gregkh, mdharm-usb, sshtylyov, bvanassche,
	linux-usb, linux-scsi, linux-kernel, Namjae Jeon, Pankaj Kumar,
	Amit Sahrawat

On Mon, 11 Jun 2012, Namjae Jeon wrote:

> Update information of Seagate Portable HDD and WD My Passport HDD in
> quirk list.
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Pankaj Kumar <pankaj.km@samsung.com>
> Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
> ---
>  drivers/usb/storage/unusual_devs.h |   24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index 1719886..64f0369 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -1267,6 +1267,18 @@ UNUSUAL_DEV( 0x0af0, 0xd357, 0x0000, 0x0000,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		0 ),
>  
> +/* Reported by Namjae Jeon <namjae.jeon@samsung.com>
> + * Even though write cache is enabled by default,
> + * SCSI driver assume that cache is not enabled
> + * which in turn might lead to the loss of data
> + * since data still will be in cache.
> + * So this entry is needed for assuming that cache is enabled.
> + */

Please remove everything except the "Reported by" line.  The rest is 
obvious when we see the US_FL_WRITE_CACHE flag.

> +UNUSUAL_DEV(0x0bc2, 0x2300, 0x0000, 0x9999,
> +		"Seagate",
> +		"Portable HDD",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
> +
>  /* Reported by Ben Efros <ben@pc-doctor.com> */
>  UNUSUAL_DEV( 0x0bc2, 0x3010, 0x0000, 0x0000,
>  		"Seagate",
> @@ -1468,6 +1480,18 @@ UNUSUAL_DEV(  0x1058, 0x0704, 0x0000, 0x9999,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		US_FL_SANE_SENSE),
>  
> +/* Reported by Namjae Jeon <namjae.jeon@samsung.com>
> + * Even though write cache is enabled by default,
> + * SCSI driver assume that cache is not enabled
> + * which in turn might lead to the loss of data
> + * since data still will be in cache.
> + * So this entry is needed for assuming that cache is enabled.
> + */

Same here.

> +UNUSUAL_DEV(0x1058, 0x070a, 0x0000, 0x9999,
> +		"Western Digital",
> +		"My Passport HDD",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),

Alan Stern

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v4 3/3] usb: storage: update usb devices for write cache quirk in quirk list.
  2012-06-11 14:19 ` Alan Stern
@ 2012-06-11 22:45   ` Namjae Jeon
  0 siblings, 0 replies; 8+ messages in thread
From: Namjae Jeon @ 2012-06-11 22:45 UTC (permalink / raw)
  To: Alan Stern
  Cc: James.Bottomley, gregkh, mdharm-usb, sshtylyov, bvanassche,
	linux-usb, linux-scsi, linux-kernel, Namjae Jeon, Pankaj Kumar,
	Amit Sahrawat

2012/6/11, Alan Stern <stern@rowland.harvard.edu>:
> On Mon, 11 Jun 2012, Namjae Jeon wrote:
>
>> Update information of Seagate Portable HDD and WD My Passport HDD in
>> quirk list.
>>
>> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
>> Signed-off-by: Pankaj Kumar <pankaj.km@samsung.com>
>> Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
>> ---
>>  drivers/usb/storage/unusual_devs.h |   24 ++++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>
>> diff --git a/drivers/usb/storage/unusual_devs.h
>> b/drivers/usb/storage/unusual_devs.h
>> index 1719886..64f0369 100644
>> --- a/drivers/usb/storage/unusual_devs.h
>> +++ b/drivers/usb/storage/unusual_devs.h
>> @@ -1267,6 +1267,18 @@ UNUSUAL_DEV( 0x0af0, 0xd357, 0x0000, 0x0000,
>>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>>  		0 ),
>>
>> +/* Reported by Namjae Jeon <namjae.jeon@samsung.com>
>> + * Even though write cache is enabled by default,
>> + * SCSI driver assume that cache is not enabled
>> + * which in turn might lead to the loss of data
>> + * since data still will be in cache.
>> + * So this entry is needed for assuming that cache is enabled.
>> + */
>
> Please remove everything except the "Reported by" line.  The rest is
> obvious when we see the US_FL_WRITE_CACHE flag.
Okay, I will remove.
Thanks~
>
>> +UNUSUAL_DEV(0x0bc2, 0x2300, 0x0000, 0x9999,
>> +		"Seagate",
>> +		"Portable HDD",
>> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
>> +
>>  /* Reported by Ben Efros <ben@pc-doctor.com> */
>>  UNUSUAL_DEV( 0x0bc2, 0x3010, 0x0000, 0x0000,
>>  		"Seagate",
>> @@ -1468,6 +1480,18 @@ UNUSUAL_DEV(  0x1058, 0x0704, 0x0000, 0x9999,
>>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>>  		US_FL_SANE_SENSE),
>>
>> +/* Reported by Namjae Jeon <namjae.jeon@samsung.com>
>> + * Even though write cache is enabled by default,
>> + * SCSI driver assume that cache is not enabled
>> + * which in turn might lead to the loss of data
>> + * since data still will be in cache.
>> + * So this entry is needed for assuming that cache is enabled.
>> + */
>
> Same here.
>
>> +UNUSUAL_DEV(0x1058, 0x070a, 0x0000, 0x9999,
>> +		"Western Digital",
>> +		"My Passport HDD",
>> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
>
> Alan Stern
>
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2012-06-13 15:28 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-13 15:28 [PATCH v4 3/3] usb: storage: update usb devices for write cache quirk in quirk list Namjae Jeon
  -- strict thread matches above, loose matches on Subject: below --
2012-06-12 14:26 Namjae Jeon
2012-06-12 14:31 ` Alan Stern
2012-06-13  1:11 ` Greg KH
     [not found]   ` <20120613011114.GF6765-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2012-06-13  1:27     ` Namjae Jeon
2012-06-11 13:29 Namjae Jeon
2012-06-11 14:19 ` Alan Stern
2012-06-11 22:45   ` Namjae Jeon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).