From mboxrd@z Thu Jan 1 00:00:00 1970 From: Namjae Jeon Subject: [PATCH RESEND 0/3] scsi: fix internal write cache issue on usb hdd. Date: Sat, 7 Jul 2012 23:04:45 -0400 Message-ID: <1341716685-6631-1-git-send-email-linkinjeon@gmail.com> Return-path: Sender: linux-kernel-owner@vger.kernel.org To: James.Bottomley@HansenPartnership.com, gregkh@linuxfoundation.org, mdharm-usb@one-eyed-alien.net, stern@rowland.harvard.edu, sshtylyov@mvista.com, bvanassche@acm.org, akpm@linux-foundation.org Cc: linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Namjae Jeon , Namjae Jeon List-Id: linux-scsi@vger.kernel.org From: Namjae Jeon The numbers of USB HDDs(All USB HDD I checked) does not respond correctly to scsi mode sense command for retrieving the write cache page status. Even though write cache is enabled by default, due to scsi driver assume that cache is not enabled which in turn might lead to loss of data since data still will be in cache. This result that all filesystems is not stable on USB HDD when the device is unplugged abruptly, even though these are having journaling feature. Our first trying is that scsi driver send ATA command (ATA Pass through, #85) to USB HDD after failure from normal routine to know write cache enable. We have known it is dangerous after testing several USB HDD. some of HDD is stalled by this command(A-DATA HDD). So we tried to make the patch James Bottomley's suggestion(usb quirk) on version 2 that add product ID and verdor ID of USB HDD to USB quirk list after checking write cache. All filesystem will be stable on USB HDD registered in quirk list. And it will be updated continuously. Namjae Jeon (3): scsi: set to WCE if usb cache quirk is present. usb: storage: add support for write cache quirk. usb: storage: update usb devices for write cache quirk in quirk. drivers/scsi/sd.c | 9 +++++++-- include/scsi/scsi_device.h | 1 + drivers/usb/storage/scsiglue.c | 5 +++++ drivers/usb/storage/usb.c | 5 ++++- include/linux/usb_usual.h | 4 +++- drivers/usb/storage/unusual_devs.h | 24 ++++++++++++++++++++++++ Documentation/kernel-parameters.txt | 2 ++ 7 files changed, 46 insertions(+), 4 deletions(-) -- 1.7.9.5