[PATCH RESEND 0/3] scsi: fix internal write cache issue on usb hdd.

[PATCH RESEND 0/3] scsi: fix internal write cache issue on usb hdd.

[Namjae Jeon]

From: Namjae Jeon <namjae.jeon@samsung.com>

The numbers of USB HDDs(All USB HDD I checked) does not respond
correctly to scsi mode sense command for retrieving the write cache
page status. Even though write cache is enabled by default, due to
scsi driver assume that cache is not enabled which in turn might lead
to loss of data since data still will be in cache.
This result that all filesystems is not stable on USB HDD when the
device is unplugged abruptly, even though these are having journaling
feature. Our first trying is that scsi driver send ATA command
(ATA Pass through, #85) to USB HDD after failure from normal routine to
know write cache enable.
We have known it is dangerous after testing several USB HDD. some of
HDD is stalled by this command(A-DATA HDD). So we tried to make the
patch James Bottomley's suggestion(usb quirk) on version 2 that add
product ID and verdor ID of USB HDD to USB quirk list after checking
write cache.
All filesystem will be stable on USB HDD registered in quirk list.
And it will be updated continuously.

Namjae Jeon (3):
	scsi: set to WCE if usb cache quirk is present.
	usb: storage: add support for write cache quirk.
	usb: storage: update usb devices for write cache quirk in quirk.

 drivers/scsi/sd.c          |    9 +++++++--
 include/scsi/scsi_device.h |    1 +
 drivers/usb/storage/scsiglue.c |    5 +++++
 drivers/usb/storage/usb.c      |    5 ++++-
 include/linux/usb_usual.h      |    4 +++-
 drivers/usb/storage/unusual_devs.h |   24 ++++++++++++++++++++++++
 Documentation/kernel-parameters.txt |    2 ++
 7 files changed, 46 insertions(+), 4 deletions(-)
-- 
1.7.9.5

Re: [PATCH RESEND 0/3] scsi: fix internal write cache issue on usb hdd.

[Greg KH]

On Sat, Jul 07, 2012 at 11:04:45PM -0400, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
> 
> The numbers of USB HDDs(All USB HDD I checked) does not respond
> correctly to scsi mode sense command for retrieving the write cache
> page status. Even though write cache is enabled by default, due to
> scsi driver assume that cache is not enabled which in turn might lead
> to loss of data since data still will be in cache.
> This result that all filesystems is not stable on USB HDD when the
> device is unplugged abruptly, even though these are having journaling
> feature. Our first trying is that scsi driver send ATA command
> (ATA Pass through, #85) to USB HDD after failure from normal routine to
> know write cache enable.
> We have known it is dangerous after testing several USB HDD. some of
> HDD is stalled by this command(A-DATA HDD). So we tried to make the
> patch James Bottomley's suggestion(usb quirk) on version 2 that add
> product ID and verdor ID of USB HDD to USB quirk list after checking
> write cache.
> All filesystem will be stable on USB HDD registered in quirk list.
> And it will be updated continuously.

Now applied to the usb-next branch.

thanks,

greg k-h

Re: [PATCH RESEND 0/3] scsi: fix internal write cache issue on usb hdd.

[James Bottomley]

On Mon, 2012-07-16 at 16:48 -0700, Greg KH wrote:
> On Sat, Jul 07, 2012 at 11:04:45PM -0400, Namjae Jeon wrote:
> > From: Namjae Jeon <namjae.jeon-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > 
> > The numbers of USB HDDs(All USB HDD I checked) does not respond
> > correctly to scsi mode sense command for retrieving the write cache
> > page status. Even though write cache is enabled by default, due to
> > scsi driver assume that cache is not enabled which in turn might lead
> > to loss of data since data still will be in cache.
> > This result that all filesystems is not stable on USB HDD when the
> > device is unplugged abruptly, even though these are having journaling
> > feature. Our first trying is that scsi driver send ATA command
> > (ATA Pass through, #85) to USB HDD after failure from normal routine to
> > know write cache enable.
> > We have known it is dangerous after testing several USB HDD. some of
> > HDD is stalled by this command(A-DATA HDD). So we tried to make the
> > patch James Bottomley's suggestion(usb quirk) on version 2 that add
> > product ID and verdor ID of USB HDD to USB quirk list after checking
> > write cache.
> > All filesystem will be stable on USB HDD registered in quirk list.
> > And it will be updated continuously.
> 
> Now applied to the usb-next branch.

It's been in scsi#misc for ten days with no problems.  Lets leave it
there rather than create merge and rebase issues.

Thanks,

James


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH RESEND 0/3] scsi: fix internal write cache issue on usb hdd.

[Greg KH]

On Tue, Jul 17, 2012 at 08:19:14AM +0100, James Bottomley wrote:
> On Mon, 2012-07-16 at 16:48 -0700, Greg KH wrote:
> > On Sat, Jul 07, 2012 at 11:04:45PM -0400, Namjae Jeon wrote:
> > > From: Namjae Jeon <namjae.jeon@samsung.com>
> > > 
> > > The numbers of USB HDDs(All USB HDD I checked) does not respond
> > > correctly to scsi mode sense command for retrieving the write cache
> > > page status. Even though write cache is enabled by default, due to
> > > scsi driver assume that cache is not enabled which in turn might lead
> > > to loss of data since data still will be in cache.
> > > This result that all filesystems is not stable on USB HDD when the
> > > device is unplugged abruptly, even though these are having journaling
> > > feature. Our first trying is that scsi driver send ATA command
> > > (ATA Pass through, #85) to USB HDD after failure from normal routine to
> > > know write cache enable.
> > > We have known it is dangerous after testing several USB HDD. some of
> > > HDD is stalled by this command(A-DATA HDD). So we tried to make the
> > > patch James Bottomley's suggestion(usb quirk) on version 2 that add
> > > product ID and verdor ID of USB HDD to USB quirk list after checking
> > > write cache.
> > > All filesystem will be stable on USB HDD registered in quirk list.
> > > And it will be updated continuously.
> > 
> > Now applied to the usb-next branch.
> 
> It's been in scsi#misc for ten days with no problems.  Lets leave it
> there rather than create merge and rebase issues.

No need for rebasing.  It's already in my tree, so we can handle the
merge when this hits Linus's tree.

thanks,

greg k-h