From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: [PATCH 1/4] sd: SCSI error codes must not be returned to generic code Date: Thu, 2 Aug 2012 12:27:04 +0200 Message-ID: <1343903227-17285-2-git-send-email-oliver@neukum.org> References: <1343903227-17285-1-git-send-email-oliver@neukum.org> Return-path: Received: from smtp-out003.kontent.com ([81.88.40.217]:36383 "EHLO smtp-out003.kontent.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753733Ab2HBK2L (ORCPT ); Thu, 2 Aug 2012 06:28:11 -0400 In-Reply-To: <1343903227-17285-1-git-send-email-oliver@neukum.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: JBottomley@parallels.com, linux-scsi@vger.kernel.org, hare@suse.de Cc: Oliver Neukum , Oliver Neukum sd_start_stop_device leaks SCSI specific error codes to the generic driver code Signed-off-by: Oliver Neukum --- drivers/scsi/sd.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 4df73e5..cef06f5 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -2830,7 +2830,11 @@ static int sd_start_stop_device(struct scsi_disk *sdkp, int start) sd_print_sense_hdr(sdkp, &sshdr); } - return res; + /* SCSI error codes must not go to the generic layer */ + if (res) + return -EIO; + + return 0; } /* -- 1.7.7