From: Joe Perches <joe@perches.com>
To: Masatake YAMATO <yamato@redhat.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] be2iscsi: cleanup format strings using literal string concatenations
Date: Sun, 12 Aug 2012 10:05:04 -0700 [thread overview]
Message-ID: <1344791104.3810.2.camel@joe2Laptop> (raw)
In-Reply-To: <1344785130-24172-1-git-send-email-yamato@redhat.com>
On Mon, 2012-08-13 at 00:25 +0900, Masatake YAMATO wrote:
> In format strings for printk in be2iscsi, literal c string
> concatenations are used widely. However, the log output is a bit
> difficult to read because whitespaces are missed in the literal c
> strings like:
>
> SE_DEBUG(DBG_LVL_1, "CQ Error %d, reset"
> "received/sent on CID 0x%x...\n",
>
> You will see "CQ Error 0xffffffff resetreceived/sent on CID ..." and
> wonder what is "resetreceived".
It'd be even better to coalesce the formats so they'd be
easier to grep. Just ignore 80 columns.
SE_DEBUG(DBG_LVL_1,
"CQ Error %d, reset received/sent on CID 0x%x...\n",
prev parent reply other threads:[~2012-08-12 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-12 15:25 [PATCH] be2iscsi: cleanup format strings using literal string concatenations Masatake YAMATO
2012-08-12 17:05 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344791104.3810.2.camel@joe2Laptop \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=yamato@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox