From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Nicholas A. Bellinger" Subject: Re: [patch] target/iscsi: precedence bug in iscsit_set_dataout_sequence_values() Date: Tue, 02 Oct 2012 13:30:00 -0700 Message-ID: <1349209800.28145.66.camel@haakon2.linux-iscsi.org> References: <20121002082248.GB12398@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.linux-iscsi.org ([67.23.28.174]:58043 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755103Ab2JBUaD (ORCPT ); Tue, 2 Oct 2012 16:30:03 -0400 In-Reply-To: <20121002082248.GB12398@elgon.mountain> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Dan Carpenter Cc: Andy Grover , Christoph Hellwig , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kernel-janitors@vger.kernel.org On Tue, 2012-10-02 at 11:22 +0300, Dan Carpenter wrote: > Clang warns about this bug: > drivers/target/iscsi/iscsi_target_erl0.c:52:45: warning: operator '?:' > has lower precedence than '+'; '+' will be evaluated first > [-Wparentheses] > > Signed-off-by: Dan Carpenter > --- > Please review this very carefully because I haven't tested it. It could > be that the check should be: > (data_done + data_length > FirstBurstLength) ? FirstBurstLength : data_length); > Instead of what I have which is: > data_done + (data_length > FirstBurstLength ? FirstBurstLength : data_length); > > diff --git a/drivers/target/iscsi/iscsi_target_erl0.c b/drivers/target/iscsi/iscsi_target_erl0.c > index 1a02016..2067efd 100644 > --- a/drivers/target/iscsi/iscsi_target_erl0.c > +++ b/drivers/target/iscsi/iscsi_target_erl0.c > @@ -48,9 +48,9 @@ void iscsit_set_dataout_sequence_values( > if (cmd->unsolicited_data) { > cmd->seq_start_offset = cmd->write_data_done; > cmd->seq_end_offset = (cmd->write_data_done + > - (cmd->se_cmd.data_length > > - conn->sess->sess_ops->FirstBurstLength) ? > - conn->sess->sess_ops->FirstBurstLength : cmd->se_cmd.data_length); > + ((cmd->se_cmd.data_length > > + conn->sess->sess_ops->FirstBurstLength) ? > + conn->sess->sess_ops->FirstBurstLength : cmd->se_cmd.data_length)); > return; > } > > -- This is indeed the original intention and your patch is correct, so applied to for-next. Thank you! --nab