Re: [PATCH-v2 1/4] target: Add target_submit_cmd_map_sgls for SGL fabric memory passthrough

["Nicholas A. Bellinger" <nab@linux-iscsi.org>]

On Tue, 2012-10-02 at 21:16 +0000, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@linux-iscsi.org>
> 
> This patch adds a new target_submit_cmd_map_sgls() to pass pre-allocated
> SGL memory using transport_generic_map_mem_to_cmd() logic into the generic
> target submit I/O codepath.
> 
> It also adds a target_submit_cmd() wrapper around target_submit_cmd_map_sgls()
> for existing fabric code that already assumes internal target-core SGL memory
> allocation.
> 
> (v2: Rename to target_submit_cmd_map_sgls + drop TARGET_SCF_MAP_MEM flag
>      in favor of non zero sgl_count check)
> 
> Reported-by: Christoph Hellwig <hch@lst.de>
> Cc: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
> ---
>  drivers/target/target_core_transport.c |   65 +++++++++++++++++++++++++++++---
>  include/target/target_core_base.h      |    1 +
>  include/target/target_core_fabric.h    |    3 +
>  3 files changed, 63 insertions(+), 6 deletions(-)
> 

> diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h
> index 5be8937..6309298 100644
> --- a/include/target/target_core_base.h
> +++ b/include/target/target_core_base.h
> @@ -220,6 +220,7 @@ enum target_sc_flags_table {
>  	TARGET_SCF_BIDI_OP		= 0x01,
>  	TARGET_SCF_ACK_KREF		= 0x02,
>  	TARGET_SCF_UNKNOWN_SIZE		= 0x04,
> +	TARGET_SCF_MAP_MEM		= 0x08,
>  };

Whoops, removing this left-over bit now before pushing into for-next.