From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: John Soni Jose <sony.john-n@Emulex.Com>,
linux-scsi@vger.kernel.org,
Jayamohan Kallickal <jayamohan.kallickal@Emulex.Com>,
Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH v2 17/19] be2iscsi: Fix for MBX timeout issue
Date: Tue, 13 Nov 2012 15:34:26 -0600 [thread overview]
Message-ID: <1352842466.8317.3.camel@dabdike> (raw)
In-Reply-To: <50878E90.1000800@cs.wisc.edu>
On Wed, 2012-10-24 at 01:45 -0500, Mike Christie wrote:
> On 10/19/2012 06:15 PM, John Soni Jose wrote:
> > @@ -763,26 +750,14 @@ static int beiscsi_get_port_speed(struct Scsi_Host *shost)
> > "BS_%d : Getting Port Speed Failed\n");
> >
> > return -EBUSY;
> > - } else
> > - wait_event_interruptible(phba->ctrl.mcc_wait[tag],
> > - phba->ctrl.mcc_numtag[tag]);
> > -
> > - wrb_num = (phba->ctrl.mcc_numtag[tag] & 0x00FF0000) >> 16;
> > - extd_status = (phba->ctrl.mcc_numtag[tag] & 0x0000FF00) >> 8;
> > - status = phba->ctrl.mcc_numtag[tag] & 0x000000FF;
> > -
> > - if (status || extd_status) {
> > + }
> > + rc = beiscsi_mccq_compl(phba, tag, &wrb, NULL);
> > + if (rc) {
> > beiscsi_log(phba, KERN_ERR,
>
> There was some small whitespace issues in this patch. Maybe James will
> fix it up when it is merged. I do not know why checkpatch.pl and git did
> not warn about them.
I fixed it up. I cc'd the checkpatch.pl maintainer. No idea why it
failed to spot the extra space at line 465 in the patch.
James
prev parent reply other threads:[~2012-11-14 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 23:15 [PATCH v2 17/19] be2iscsi: Fix for MBX timeout issue John Soni Jose
2012-10-24 6:45 ` Mike Christie
2012-11-13 21:34 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352842466.8317.3.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=apw@canonical.com \
--cc=jayamohan.kallickal@Emulex.Com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=sony.john-n@Emulex.Com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).