linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 01/19] be2iscsi: Fix the issue with soft reset.
@ 2012-10-19 23:11 John Soni Jose
  2012-11-14  2:26 ` James Bottomley
  0 siblings, 1 reply; 2+ messages in thread
From: John Soni Jose @ 2012-10-19 23:11 UTC (permalink / raw)
  To: michaelc, linux-scsi; +Cc: Minh Tran, Jayamohan Kallickal

From: Minh Tran <minhduc.tran@emulex.com>

 Fixed soft_reset problem which driver modified
 all 32bit before a write on second pass.

Signed-off-by: Minh Tran <minhduc.tran@emulex.com>
Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>
---
 drivers/scsi/be2iscsi/be_cmds.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c
index 07d2cb1..05f70bb 100644
--- a/drivers/scsi/be2iscsi/be_cmds.c
+++ b/drivers/scsi/be2iscsi/be_cmds.c
@@ -56,7 +56,7 @@ int beiscsi_pci_soft_reset(struct beiscsi_hba *phba)
 	writel(pconline0, (void *)pci_online0_offset);
 	writel(pconline1, (void *)pci_online1_offset);
 
-	sreset = BE2_SET_RESET;
+	sreset |= BE2_SET_RESET;
 	writel(sreset, (void *)pci_reset_offset);
 
 	i = 0;
-- 
1.7.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 01/19] be2iscsi: Fix the issue with soft reset.
  2012-10-19 23:11 [PATCH v2 01/19] be2iscsi: Fix the issue with soft reset John Soni Jose
@ 2012-11-14  2:26 ` James Bottomley
  0 siblings, 0 replies; 2+ messages in thread
From: James Bottomley @ 2012-11-14  2:26 UTC (permalink / raw)
  To: John Soni Jose; +Cc: michaelc, linux-scsi, Minh Tran, Jayamohan Kallickal

On Sat, 2012-10-20 at 04:41 +0530, John Soni Jose wrote:
> From: Minh Tran <minhduc.tran@emulex.com>
> 
>  Fixed soft_reset problem which driver modified
>  all 32bit before a write on second pass.
> 
> Signed-off-by: Minh Tran <minhduc.tran@emulex.com>
> Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>

I'll put this in, this time, but please remember that if you send me a
patch, it needs your signoff as well.

James




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-11-14  7:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-19 23:11 [PATCH v2 01/19] be2iscsi: Fix the issue with soft reset John Soni Jose
2012-11-14  2:26 ` James Bottomley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).