* [PATCH 1/1] iscsi_target: Remove redundant null check before kfree
@ 2012-11-21 10:44 Sachin Kamat
2012-11-28 2:51 ` Nicholas A. Bellinger
0 siblings, 1 reply; 2+ messages in thread
From: Sachin Kamat @ 2012-11-21 10:44 UTC (permalink / raw)
To: linux-scsi, target-devel; +Cc: nab, sachin.kamat, patches
kfree on null pointer is a no-op.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/target/iscsi/iscsi_target_login.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c
index 7bf9ccc..fdb632f 100644
--- a/drivers/target/iscsi/iscsi_target_login.c
+++ b/drivers/target/iscsi/iscsi_target_login.c
@@ -1118,10 +1118,8 @@ new_sess_out:
idr_remove(&sess_idr, conn->sess->session_index);
spin_unlock_bh(&sess_idr_lock);
}
- if (conn->sess->sess_ops)
- kfree(conn->sess->sess_ops);
- if (conn->sess)
- kfree(conn->sess);
+ kfree(conn->sess->sess_ops);
+ kfree(conn->sess);
old_sess_out:
iscsi_stop_login_thread_timer(np);
/*
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] iscsi_target: Remove redundant null check before kfree
2012-11-21 10:44 [PATCH 1/1] iscsi_target: Remove redundant null check before kfree Sachin Kamat
@ 2012-11-28 2:51 ` Nicholas A. Bellinger
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2012-11-28 2:51 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-scsi, target-devel, patches
Hi Sachin,
On Wed, 2012-11-21 at 16:14 +0530, Sachin Kamat wrote:
> kfree on null pointer is a no-op.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
Apologies for the delayed response. Applied to target-pending/for-next.
Thank you!
--nab
> drivers/target/iscsi/iscsi_target_login.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c
> index 7bf9ccc..fdb632f 100644
> --- a/drivers/target/iscsi/iscsi_target_login.c
> +++ b/drivers/target/iscsi/iscsi_target_login.c
> @@ -1118,10 +1118,8 @@ new_sess_out:
> idr_remove(&sess_idr, conn->sess->session_index);
> spin_unlock_bh(&sess_idr_lock);
> }
> - if (conn->sess->sess_ops)
> - kfree(conn->sess->sess_ops);
> - if (conn->sess)
> - kfree(conn->sess);
> + kfree(conn->sess->sess_ops);
> + kfree(conn->sess);
> old_sess_out:
> iscsi_stop_login_thread_timer(np);
> /*
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-28 2:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-21 10:44 [PATCH 1/1] iscsi_target: Remove redundant null check before kfree Sachin Kamat
2012-11-28 2:51 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).