linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Evers <revers@redhat.com>
To: linux-scsi@vger.kernel.org
Cc: chad.dupuis@qlogic.com, giridhar.malavali@qlogic.com,
	scameron@beardog.cce.hp.com, mike.miller@hp.com,
	dan.j.williams@intel.com, fushun@marvell.com
Subject: [PATCH 0/2] Change type-2 dif to use rq embedded 32 byte cdb
Date: Wed, 21 Nov 2012 15:07:46 -0500	[thread overview]
Message-ID: <1353528468-5664-1-git-send-email-revers@redhat.com> (raw)

These patches replace the original t10 type 2 dif mempool implementation
by increasing the block and scsi cdb maximum sizes from 16 to 32 bytes.
The cdb embedded in the request structure can then be used for type 2
dif commands, or other 32 byte cdbs as required.

Motivation for this is that type-2 dif commands should be treated as
any other read/writes generally, without any performance penalty.

This patch set conflicts with a patch previously posted which addresses
a race in UA induced retries with type 2 dif commands.  These patches also
address that problem:

http://marc.info/?l=linux-scsi&m=135186352200668&w=2

Testing:

Readily reproduced the race condition panic by simultaneously
inducing UAs while load testing 8 scsi_debug devices.  With patch
applied, same testing ran for 15 hours without a panic.

Sanity tested performance using scsi_debug, with and without
type 2 dif enabled.  Order 80% performance increase noticed
with patches when scsi_debug was running in dif type 2 mode.
Running scsi_debug without type 2 dif, performance was approximately
equal.

Used 3.7.0-rc5 for testing and patch generation.

root (2):
  Change the cdb size limits in block and scsi to 32 bytes
  Change dif type 2 commands to use embedded 32 byte cdb

 drivers/scsi/sd.c        | 45 +--------------------------------------------
 drivers/scsi/sd.h        |  5 -----
 include/linux/blkdev.h   |  2 +-
 include/scsi/scsi_cmnd.h | 13 ++-----------
 4 files changed, 4 insertions(+), 61 deletions(-)

-- 
1.7.11.7

             reply	other threads:[~2012-11-21 20:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21 20:07 Rob Evers [this message]
2012-11-21 20:07 ` [PATCH 1/2] Change the cdb size limits in block and scsi to 32 bytes Rob Evers
2012-11-21 20:07 ` [PATCH 2/2] Change dif type 2 commands to use embedded 32 byte cdb Rob Evers
2012-11-26 16:25 ` [PATCH 0/2] Change type-2 dif to use rq " Rob Evers
2012-11-26 23:58 ` Martin K. Petersen
2012-11-27 16:12   ` Rob Evers
2012-12-19 14:12 ` Rob Evers
  -- strict thread matches above, loose matches on Subject: below --
2012-12-19 10:34 Scott Guthridge
2012-12-19 16:55 ` Martin K. Petersen
2012-12-19 17:28   ` Elliott, Robert (Server Storage)
2012-12-30  0:52 ` Douglas Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353528468-5664-1-git-send-email-revers@redhat.com \
    --to=revers@redhat.com \
    --cc=chad.dupuis@qlogic.com \
    --cc=dan.j.williams@intel.com \
    --cc=fushun@marvell.com \
    --cc=giridhar.malavali@qlogic.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mike.miller@hp.com \
    --cc=scameron@beardog.cce.hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).