* [PATCH] scsi/aacraid: user upper/lower_address() macro to avoid "right shift count >= width of type" warning.
@ 2012-11-21 20:50 Sebastian Andrzej Siewior
0 siblings, 0 replies; only message in thread
From: Sebastian Andrzej Siewior @ 2012-11-21 20:50 UTC (permalink / raw)
To: Adaptec OEM Raid Solutions
Cc: James E.J. Bottomley, linux-scsi, Sebastian Andrzej Siewior
Avoids the following warning:
|drivers/scsi/aacraid/src.c: In function 'aac_src_deliver_message':
|drivers/scsi/aacraid/src.c:410:3: warning: right shift count >= width of type [enabled by default]
| BUG_ON((u32)(address >> 32) != 0L);
| ^
|drivers/scsi/aacraid/src.c:434:2: warning: right shift count >= width of type [enabled by default]
| src_writel(dev, MUnit.IQ_H, (address >> 32) & 0xffffffff);
Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
---
drivers/scsi/aacraid/src.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c
index 3b021ec..4f6388e 100644
--- a/drivers/scsi/aacraid/src.c
+++ b/drivers/scsi/aacraid/src.c
@@ -407,7 +407,7 @@ static int aac_src_deliver_message(struct fib *fib)
fib->hw_fib_va->header.StructType = FIB_MAGIC2;
fib->hw_fib_va->header.SenderFibAddress = (u32)address;
fib->hw_fib_va->header.u.TimeStamp = 0;
- BUG_ON((u32)(address >> 32) != 0L);
+ BUG_ON((upper_32_bits(address) != 0L));
address |= fibsize;
} else {
/* Calculate the amount to the fibsize bits */
@@ -431,8 +431,8 @@ static int aac_src_deliver_message(struct fib *fib)
address |= fibsize;
}
- src_writel(dev, MUnit.IQ_H, (address >> 32) & 0xffffffff);
- src_writel(dev, MUnit.IQ_L, address & 0xffffffff);
+ src_writel(dev, MUnit.IQ_H, upper_32_bits(address));
+ src_writel(dev, MUnit.IQ_L, lower_32_bits(address));
return 0;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-11-21 20:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-21 20:50 [PATCH] scsi/aacraid: user upper/lower_address() macro to avoid "right shift count >= width of type" warning Sebastian Andrzej Siewior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).