linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	JBottomley@parallels.com
Cc: Bart Van Assche <bvanassche@acm.org>
Subject: [patch,v3,repost 00/10] make I/O path allocations more numa-friendly
Date: Tue, 27 Nov 2012 11:46:28 -0500	[thread overview]
Message-ID: <1354034799-8460-1-git-send-email-jmoyer@redhat.com> (raw)

Hi,

This patch set makes memory allocations for data structures used in
the I/O path more numa friendly by allocating them from the same numa
node as the storage device.  I've only converted a handful of drivers
at this point.  My testing is limited by the hardware I have on hand.
Using these patches, I was able to max out the bandwidth of the storage
controller when issuing I/O from any node on my 4 node system.  Without
the patch, I/O from nodes remote to the storage device would suffer a
penalty ranging from 6-12%.  Given my relatively low-end setup[1], I
wouldn't be surprised if others could show a more significant performance
advantage.

This is a repost of the last posting.  The only changes are additional
reviewed-by/acked-by tags.  I think this version is ready for inclusion.
James, would you mind taking a look?

Cheers,
Jeff

[1] LSI Megaraid SAS controller with 1GB battery-backed cache,
fronting a RAID 6 10+2.  The workload I used was tuned to not
have to hit disk.  Fio file attached.

--
changes from v2->v3:
- Made the numa_node Scsi_Host structure member dependent on CONFIG_NUMA
- Got rid of a GFP_ZERO I added accidentally
changes from v1->v2:
- got rid of the vfs patch, as Al pointed out some fundamental
  problems with it
- credited Bart van Assche properly


Jeff Moyer (10):
  scsi: add scsi_host_alloc_node
  scsi: make __scsi_alloc_queue numa-aware
  scsi: make scsi_alloc_sdev numa-aware
  scsi: allocate scsi_cmnd-s from the device's local numa node
  sd: use alloc_disk_node
  ata: use scsi_host_alloc_node
  megaraid_sas: use scsi_host_alloc_node
  mpt2sas: use scsi_host_alloc_node
  lpfc: use scsi_host_alloc_node
  cciss: use blk_init_queue_node

 drivers/ata/libata-scsi.c                 |    3 ++-
 drivers/block/cciss.c                     |    3 ++-
 drivers/scsi/hosts.c                      |   13 +++++++++++--
 drivers/scsi/lpfc/lpfc_init.c             |   10 ++++++----
 drivers/scsi/megaraid/megaraid_sas_base.c |    5 +++--
 drivers/scsi/mpt2sas/mpt2sas_scsih.c      |    4 ++--
 drivers/scsi/scsi.c                       |   16 ++++++++++------
 drivers/scsi/scsi_lib.c                   |    3 ++-
 drivers/scsi/scsi_scan.c                  |    4 ++--
 drivers/scsi/sd.c                         |    2 +-
 include/scsi/scsi_host.h                  |   28 ++++++++++++++++++++++++++++
 11 files changed, 69 insertions(+), 22 deletions(-)

             reply	other threads:[~2012-11-27 16:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-27 16:46 Jeff Moyer [this message]
2012-11-27 16:46 ` [patch,v3,repost 01/10] scsi: add scsi_host_alloc_node Jeff Moyer
2012-11-27 16:46 ` [patch,v3,repost 02/10] scsi: make __scsi_alloc_queue numa-aware Jeff Moyer
2012-11-27 16:46 ` [patch,v3,repost 03/10] scsi: make scsi_alloc_sdev numa-aware Jeff Moyer
2012-11-27 16:46 ` [patch,v3,repost 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node Jeff Moyer
2012-11-27 16:46 ` [patch,v3,repost 05/10] sd: use alloc_disk_node Jeff Moyer
2012-11-27 16:46 ` [patch,v3,repost 06/10] ata: use scsi_host_alloc_node Jeff Moyer
2012-11-27 16:46 ` [patch,v3,repost 07/10] megaraid_sas: " Jeff Moyer
2012-12-04  1:41   ` adam radford
2012-11-27 16:46 ` [patch,v3,repost 08/10] mpt2sas: " Jeff Moyer
2012-11-27 16:46 ` [patch,v3,repost 09/10] lpfc: " Jeff Moyer
2012-11-27 16:46 ` [patch,v3,repost 10/10] cciss: use blk_init_queue_node Jeff Moyer
2012-12-10 17:59 ` [patch,v3,repost 00/10] make I/O path allocations more numa-friendly Jeff Moyer
2012-12-11 10:13   ` James Bottomley
2012-12-14 16:05     ` Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354034799-8460-1-git-send-email-jmoyer@redhat.com \
    --to=jmoyer@redhat.com \
    --cc=JBottomley@parallels.com \
    --cc=bvanassche@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).