* [PATCH] iscsit: use GFP_ATOMIC under spin lock
@ 2012-11-23 4:07 Wei Yongjun
2012-11-28 2:53 ` Nicholas A. Bellinger
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-11-23 4:07 UTC (permalink / raw)
To: nab; +Cc: yongjun_wei, linux-scsi, target-devel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
The function iscsit_build_conn_drop_async_message() is called
from iscsit_close_connection() with spin lock 'sess->conn_lock'
held, so we should use GFP_ATOMIC instead of GFP_KERNEL.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/target/iscsi/iscsi_target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index 035c2c7..3983ad3 100644
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -2360,7 +2360,7 @@ static void iscsit_build_conn_drop_async_message(struct iscsi_conn *conn)
if (!conn_p)
return;
- cmd = iscsit_allocate_cmd(conn_p, GFP_KERNEL);
+ cmd = iscsit_allocate_cmd(conn_p, GFP_ATOMIC);
if (!cmd) {
iscsit_dec_conn_usage_count(conn_p);
return;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iscsit: use GFP_ATOMIC under spin lock
2012-11-23 4:07 [PATCH] iscsit: use GFP_ATOMIC under spin lock Wei Yongjun
@ 2012-11-28 2:53 ` Nicholas A. Bellinger
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2012-11-28 2:53 UTC (permalink / raw)
To: Wei Yongjun; +Cc: yongjun_wei, linux-scsi, target-devel
Hi Wei,
On Fri, 2012-11-23 at 12:07 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> The function iscsit_build_conn_drop_async_message() is called
> from iscsit_close_connection() with spin lock 'sess->conn_lock'
> held, so we should use GFP_ATOMIC instead of GFP_KERNEL.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
Nice catch here. Applied to target-pending/for-next, and including a CC
to stable.
Thank you!
--nab
> drivers/target/iscsi/iscsi_target.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> index 035c2c7..3983ad3 100644
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -2360,7 +2360,7 @@ static void iscsit_build_conn_drop_async_message(struct iscsi_conn *conn)
> if (!conn_p)
> return;
>
> - cmd = iscsit_allocate_cmd(conn_p, GFP_KERNEL);
> + cmd = iscsit_allocate_cmd(conn_p, GFP_ATOMIC);
> if (!cmd) {
> iscsit_dec_conn_usage_count(conn_p);
> return;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe target-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-28 2:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-23 4:07 [PATCH] iscsit: use GFP_ATOMIC under spin lock Wei Yongjun
2012-11-28 2:53 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).