linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hiral Patel <hiralpat@cisco.com>
To: linux-scsi@vger.kernel.org
Cc: JBottomley@parallels.com, Hiral Patel <hiralpat@cisco.com>,
	Sesidhar Baddela <sebaddel@cisco.com>
Subject: [PATCH 04/10] fnic: Fix SGEs limit
Date: Mon, 10 Dec 2012 01:21:32 -0800	[thread overview]
Message-ID: <1355131299-3313-4-git-send-email-hiralpat@cisco.com> (raw)
In-Reply-To: <1355131299-3313-1-git-send-email-hiralpat@cisco.com>

Driver allows IOs with more SGEs than max SGEs supported by Palo. The current max SGEs
supported by the fnic driver is 1024. The current register settings on Palo supports
a max of 256 only. Palo would return any IO with more than 256 SGEs with an error
indicating INVALID_SGLS. Fnic driver should limit the max supported SGLs in
the driver to 256 to avoid this error.

Signed-off-by: Sesidhar Baddela <sebaddel@cisco.com>
Signed-off-by: Hiral Patel <hiralpat@cisco.com>
---
 drivers/scsi/fnic/fnic_io.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/fnic/fnic_io.h b/drivers/scsi/fnic/fnic_io.h
index f0b8969..3455c34 100644
--- a/drivers/scsi/fnic/fnic_io.h
+++ b/drivers/scsi/fnic/fnic_io.h
@@ -21,7 +21,7 @@
 #include <scsi/fc/fc_fcp.h>
 
 #define FNIC_DFLT_SG_DESC_CNT  32
-#define FNIC_MAX_SG_DESC_CNT        1024    /* Maximum descriptors per sgl */
+#define FNIC_MAX_SG_DESC_CNT        256     /* Maximum descriptors per sgl */
 #define FNIC_SG_DESC_ALIGN          16      /* Descriptor address alignment */
 
 struct host_sg_desc {
-- 
1.7.9.5


  parent reply	other threads:[~2012-12-10  9:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-10  9:21 [PATCH 01/10] fnic: updated MAINTAINERS list Hiral Patel
2012-12-10  9:21 ` [PATCH 02/10] fnic: fix for trusted cos Hiral Patel
2012-12-10  9:21 ` [PATCH 03/10] fnic:fixing issues in device and firmware reset code Hiral Patel
2012-12-10  9:21 ` Hiral Patel [this message]
2012-12-10  9:21 ` [PATCH 05/10] fnic: fnic driver may hit BUG_ON on device reset Hiral Patel
2012-12-17 11:24   ` James Bottomley
2012-12-17 23:36     ` Hiral Patel (hiralpat)
2012-12-10  9:21 ` [PATCH 06/10] fnic: New debug flags and debug log messages Hiral Patel
2012-12-10  9:21 ` [PATCH 07/10] fnic: Fnic Trace Utility Hiral Patel
2012-12-10  9:21 ` [PATCH 08/10] fnic: FIP VLAN Discovery Feature Support Hiral Patel
2012-12-10  9:21 ` [PATCH 9/9] fnic: FIP configuration mismatch between switch and adapter crashes driver Hiral Patel
2012-12-10  9:38   ` James Bottomley
2012-12-10  9:45     ` Hiral Patel (hiralpat)
2012-12-10  9:21 ` [PATCH 09/10] fnic: Kernel panic due to FIP mode misconfiguration Hiral Patel
2012-12-10  9:21 ` [PATCH 10/10] fnic: Incremented driver version Hiral Patel
  -- strict thread matches above, loose matches on Subject: below --
2013-01-30  0:05 [PATCH 03/10] fnic:fixing issues in device and firmware reset code Hiral Patel
2013-01-30  0:05 ` [PATCH 04/10] fnic: Fix SGEs limit Hiral Patel
2013-02-13  1:00 [PATCH 03/10] fnic:fixing issues in device and firmware reset code Hiral Patel
2013-02-13  1:00 ` [PATCH 04/10] fnic: Fix SGEs limit Hiral Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355131299-3313-4-git-send-email-hiralpat@cisco.com \
    --to=hiralpat@cisco.com \
    --cc=JBottomley@parallels.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sebaddel@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).